Deprecate the #[recursive] attribute from functions
#6185
Assignees
Comments
|
This is going to be a pretty decently sized breaking change as we're going to have to:
|
AztecBot
pushed a commit
to AztecProtocol/barretenberg
that referenced
this issue
Nov 2, 2024
…(#9479) Resolves noir-lang/noir#6185 * Remove the `recursive` field from ACIR formats and the `Circuit` definition * Add `--recursive` to `bb` CLI * Add `recursive` to `main.ts`, the backend API and Wasm This is effectively undoing a lot of what was done [here](AztecProtocol/aztec-packages@9c965a7#diff-2b9fe3a6f248b96aefc37782cc4c321567eed5dd10ab24472620a68c0fb4506bR29). Interestingly there many more Wasm methods that need the `recursive` parameter now: whereas previously only `acir_create_proof` and `acir_verify_proof` used it, now anything that calls `create_circuit` needs it because circuit creation builds all the constraints already, which depend on this. TODO: - [x] Remove the `#[recursive]` attribute from Noir - [x] Should the "prove and verify" methods that return nothing have a recursive parameter? - [x] Remove `#[recursive]` from `noir-protocol-circuits` - [x] Update `bb-prover` where it uses uses `noir-protocol-circuits` to use the correct `recursive` flag - [x] Add `--recursive` to `cli.ts` under `bb-prover` - [x] Check all calls to `executeBB` and pass `--recursive` if it calls a `bb` command that needs it --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Tom French <tom@tomfren.ch>
AztecBot
pushed a commit
to AztecProtocol/aztec-nr
that referenced
this issue
Nov 2, 2024
…(#9479) Resolves noir-lang/noir#6185 * Remove the `recursive` field from ACIR formats and the `Circuit` definition * Add `--recursive` to `bb` CLI * Add `recursive` to `main.ts`, the backend API and Wasm This is effectively undoing a lot of what was done [here](AztecProtocol/aztec-packages@9c965a7#diff-2b9fe3a6f248b96aefc37782cc4c321567eed5dd10ab24472620a68c0fb4506bR29). Interestingly there many more Wasm methods that need the `recursive` parameter now: whereas previously only `acir_create_proof` and `acir_verify_proof` used it, now anything that calls `create_circuit` needs it because circuit creation builds all the constraints already, which depend on this. TODO: - [x] Remove the `#[recursive]` attribute from Noir - [x] Should the "prove and verify" methods that return nothing have a recursive parameter? - [x] Remove `#[recursive]` from `noir-protocol-circuits` - [x] Update `bb-prover` where it uses uses `noir-protocol-circuits` to use the correct `recursive` flag - [x] Add `--recursive` to `cli.ts` under `bb-prover` - [x] Check all calls to `executeBB` and pass `--recursive` if it calls a `bb` command that needs it --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Tom French <tom@tomfren.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This attribute was added at the point where barretenberg was compiled into nargo and so we needed a way inside of Noir to specify whether
nargo proveshould generate a recursive proof. As this is no longer the case it makes more sense to allow the user to generate different types of proof by selecting this on the CLI when interacting with their chosen backend.We should deprecate this attribute and remove it so we don't need to track what kind of proof to generate inside of the Noir program artifact.
The text was updated successfully, but these errors were encountered: