Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Silence output of prove and verify #892

Merged
merged 3 commits into from
Feb 22, 2023
Merged

feat: Silence output of prove and verify #892

merged 3 commits into from
Feb 22, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Feb 21, 2023

Related issue(s)

Resolves #873

Description

Summary of changes

Silences output of nargo prove and nargo verify, unless either encounter an error.

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

If approved, we should likely follow this example and do this for other commands as well, where it makes sense. E.g. cargo compile.

TomAFrench
TomAFrench reviewed Feb 21, 2023
View reviewed changes
crates/nargo/src/cli/verify_cmd.rs Outdated Show resolved Hide resolved
crates/nargo/src/cli/prove_cmd.rs Outdated Show resolved Hide resolved
@jfecher jfecher changed the title Silence output of prove and verify feat: Silence output of prove and verify Feb 21, 2023
TomAFrench
TomAFrench previously approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but happy to merge after.

crates/nargo/src/cli/verify_cmd.rs Outdated Show resolved Hide resolved
@TomAFrench TomAFrench mentioned this pull request Feb 22, 2023
Merged
6 tasks
@jfecher jfecher added this pull request to the merge queue Feb 22, 2023
Merged via the queue into master with commit 811b346 Feb 22, 2023
@jfecher jfecher deleted the jf/fix-873 branch February 22, 2023 16:42
@kevaundray kevaundray mentioned this pull request Feb 22, 2023
Merged
@Savio-Sou Savio-Sou mentioned this pull request Mar 30, 2023
Closed
This was referenced Mar 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(cli): limit output for nargo prove
2 participants
@jfecher @TomAFrench