feat: Implement std::unsafe::zeroed
#1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
changed the title
std::unsafe::zeroedstd::unsafe::zeroed
kevaundray
previously approved these changes
Mar 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kevaundray
approved these changes
Mar 30, 2023
TomAFrench
added a commit
that referenced
this pull request
Apr 3, 2023
* master: chore: handle public parameters and return values separately in evaluator (#1062) chore(ssa): Rename ObjectType::Pointer to ObjectType::ArrayPointer (#1077) chore(ssa): indent NumericType into ObjectType (#810) chore: apply spelling fixes (#1073) feat: Implement `std::unsafe::zeroed` (#1048) fix: crash when typechecking fields that don't exist (#1070) feat: Implement arrays of structs (#1068) feat(nargo): split `nargo` into core and cli packages (#1065) chore: split wasm crate into submodules (#1066)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #1017
Requires #1044 to work as it renames the
unsafekeyword which is used by this PR as a module name.Part of work to implement #988
Description
Summary of changes
Implements
fn zeroed<T>() -> Tto return a zeroed value of any type. This function is generally unsafe to use as the zeroed bit pattern is not guaranteed to be valid for all types. It can however, be useful in cases when the value is guaranteed not to be used such as in aBoundedVeclibrary implementing a growable vector, up to a certain length, backed by an array. The array can be initialized with zeroed values which are guaranteed to be inaccessible until the vector is pushed to. Similarly, enumerations in noir can be implemented using this method by providing zeroed values for the unused variants.Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Add
std::unsafe::zeroedto the documentation of the standard library. Its type signature and usecases should be noted (given above in this PR), and especially the note on its potential unsafeness.Additional context