feat: Allow structs and arrays as globals #1054
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #439
Description
Summary of changes
Allows non-integers such as structs and arrays to be used as globals, as long as they're initialized as constants. There is nothing verifying the sub-expressions for these are also constants currently though, so it is possible to have unexpected behavior (calling a function which tries to use the uninitialized global internally).
Attempting to use these in an array-length context will not crash the compiler, but will issue a somewhat confusing error that can be improved later.
Dependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Documentation needs
We'll need to document that, in addition to integers, arbitrary structs and arrays can also be defined as globals. They must be initialized to struct or array literals however.
We should likely mention the sub-expressions within these struct/array literals should also be literals themselves even though this is not enforced yet.
Additional context