chore(ssa refactor): Implement ssa-gen for indexing, cast, constrain, if, unary #1225
Conversation
|
Seems my comment did not submit yesterday |
|
Can you elaborate on why JMP has block arguments but JMPIF does not? |
* master: chore: address clippy warnings (#1239) chore(ssa refactor): Implement function calls (#1235) chore(ssa refactor): Implement mutable and immutable variables (#1234) chore(ssa refactor): Fix recursive printing of blocks (#1230) feat(noir): added assert keyword (#1227) chore(ssa refactor): Implement ssa-gen for indexing, cast, constrain, if, unary (#1225) feat(noir): added `distinct` keyword (#1219)
I'm wondering the same thing. Did you add an explainer somewhere? (Have been unable to find one.) Relatedly, the comment on |
|
@joss-aztec No explainer in the code, no. It was removed mostly because we did not need it for encoding any control flow. The only situation I can think of where it would be needed would be if we switch to the other representation of mutable variables (represented by a wrapper type that automatically inserts block arguments - compared to our current representation which uses the allocate instruction and load/store instructions). So if we revisit the representation of mutable variables this change will likely come along with it. Although it'll be a slightly different form. Looking at cranelift they have different arguments for each block to jump to. We'll need that as well. |
* master: (223 commits) chore(noir): Release 0.5.0 (#1202) chore(ci): Utilize new workflow to build binaries (#1250) chore(ssa refactor): Fix loading from mutable parameters (#1248) fix(wasm): add std after dependencies (#1245) chore(ssa refactor): Fix no returns & duplicate main (#1243) chore(ssa refactor): Implement intrinsics (#1241) chore(ssa refactor): Implement first-class functions (#1238) chore: address clippy warnings (#1239) chore(ssa refactor): Implement function calls (#1235) chore(ssa refactor): Implement mutable and immutable variables (#1234) chore(ssa refactor): Fix recursive printing of blocks (#1230) feat(noir): added assert keyword (#1227) chore(ssa refactor): Implement ssa-gen for indexing, cast, constrain, if, unary (#1225) feat(noir): added `distinct` keyword (#1219) chore(nargo): update panic message to suggest searching for similar issues (#1224) chore(ssa refactor): Update how instruction result types are retrieved (#1222) chore(ssa refactor): Implement ssa-gen for binary, block, tuple, extract-tuple-field, and semi expressions (#1217) chore: add RUST_BACKTRACE environment variable to nix config (#1216) chore(ssa): Add intial control flow graph (#1200) chore(ssa refactor): Handle codegen for literals (#1209) ...
Related issue(s)
Resolves #
Description
Summary of changes
Implements ssa-gen for a few more expression types
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context