Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove poseidonsponge_x5_254 from exclusion list #1263

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

kevaundray
Copy link
Contributor

Related issue(s)

Related to #1262

Resolves #

Description

Summary of changes

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@kevaundray kevaundray changed the title fix: Remove poseidon from exclusion list fix: Remove poseidonsponge_x5_254 from exclusion list May 1, 2023
@kevaundray
Copy link
Contributor Author

Note: #1257 is still good because it shows poseidon failing and then passing once we fix the serialization

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't cause any issues with CI times now that we're just executing.

@TomAFrench TomAFrench added this pull request to the merge queue Jul 11, 2023
@TomAFrench TomAFrench removed this pull request from the merge queue due to a manual request Jul 11, 2023
@TomAFrench TomAFrench changed the title fix: Remove poseidonsponge_x5_254 from exclusion list chore: Remove poseidonsponge_x5_254 from exclusion list Jul 11, 2023
@TomAFrench TomAFrench added this pull request to the merge queue Jul 11, 2023
Merged via the queue into master with commit be0cb75 Jul 11, 2023
6 checks passed
@TomAFrench TomAFrench deleted the kw/investigate-poseidon-running-time branch July 11, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants