Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ssa refactor): Use types from ssa ir directly in acir context #1530

Merged
merged 8 commits into from
Jun 5, 2023

Conversation

kevaundray
Copy link
Contributor

Description

An example of what #1529 could look like

Problem*

Resolves

Summary*

This PR sets out to

Example

Before:


After:


Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor Author

This is still in the experimental phase and we need to be a bit careful because previously we were semantically saying that only integers can have a bit size, wheras now this allows field elements to have a fixed bit size too. The relevance being that we don't want to be able to do a comparison with a field element. This should be caught by the frontend though

Copy link
Contributor

@joss-aztec joss-aztec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit unsure about the direction of this PR. GH-1529 argues we can allow ACIR gen do less work in regards to type tracking, but it appears to be doing more.

@kevaundray
Copy link
Contributor Author

Made a quick Proof of concept (not mergable) that shows the impact of removing tracking for blackbox functions

@kevaundray kevaundray marked this pull request as ready for review June 5, 2023 12:18
@joss-aztec
Copy link
Contributor

joss-aztec commented Jun 5, 2023

Made a quick Proof of concept (not mergable) that shows the impact of removing tracking for blackbox functions

Got a link?

#1539

@kevaundray kevaundray enabled auto-merge June 5, 2023 13:57
@kevaundray kevaundray added this pull request to the merge queue Jun 5, 2023
@ghost ghost mentioned this pull request Jun 5, 2023
2 tasks
Merged via the queue into master with commit a40a590 Jun 5, 2023
@kevaundray kevaundray deleted the kw/add-ssa-types branch June 5, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants