-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ssa refactor): Use types from ssa ir directly in acir context #1530
Conversation
This is still in the experimental phase and we need to be a bit careful because previously we were semantically saying that only integers can have a bit size, wheras now this allows field elements to have a fixed bit size too. The relevance being that we don't want to be able to do a comparison with a field element. This should be caught by the frontend though |
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/acir_variable.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit unsure about the direction of this PR. GH-1529 argues we can allow ACIR gen do less work in regards to type tracking, but it appears to be doing more.
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/acir_variable.rs
Outdated
Show resolved
Hide resolved
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/acir_variable.rs
Outdated
Show resolved
Hide resolved
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/acir_variable.rs
Show resolved
Hide resolved
Made a quick Proof of concept (not mergable) that shows the impact of removing tracking for blackbox functions |
|
Description
An example of what #1529 could look like
Problem*
Resolves
Summary*
This PR sets out to
Example
Before:
After:
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.