Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace .filter().count() > 0 with .any() #1847

Merged
merged 1 commit into from
Jul 3, 2023
Merged

chore: replace .filter().count() > 0 with .any() #1847

merged 1 commit into from
Jul 3, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

Minor refactor I noticed while reviewing #1840

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

jfecher
jfecher approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TomAFrench TomAFrench enabled auto-merge July 3, 2023 08:50
@TomAFrench TomAFrench added this pull request to the merge queue Jul 3, 2023
Merged via the queue into master with commit 1d1e424 Jul 3, 2023
@TomAFrench TomAFrench deleted the has-errors-refactor branch July 3, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @jfecher