Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump ACVM version to 0.20.1 #2043

Merged
merged 2 commits into from
Jul 26, 2023
Merged

chore: Bump ACVM version to 0.20.1 #2043

merged 2 commits into from
Jul 26, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR bumps to use the new ACVM 0.20.1 release.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench changed the title chore: bump to ACVM 0.20.1 chore: Bump ACVM version to 0.20.1 Jul 26, 2023
@TomAFrench
Copy link
Member Author

This is failing on the old SSA as we're passing in more than a simple witness to the BlockSolver. We'll need to make this more flexible again in future.

@TomAFrench TomAFrench closed this Jul 26, 2023
@TomAFrench TomAFrench reopened this Jul 26, 2023
@kevaundray
Copy link
Contributor

I'll open an PR to remove testing of the legacy SSA code. We are no longer maintaining/patching it or giving guarantees that it works anymore

@kevaundray kevaundray mentioned this pull request Jul 26, 2023
5 tasks
@kevaundray kevaundray added this pull request to the merge queue Jul 26, 2023
@kevaundray kevaundray removed this pull request from the merge queue due to a manual request Jul 26, 2023
@kevaundray kevaundray added this pull request to the merge queue Jul 26, 2023
Merged via the queue into master with commit 4ecf3c4 Jul 26, 2023
@kevaundray kevaundray deleted the acvm-0.20.1 branch July 26, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants