chore: Ensure that CLI and wasm compilers are sync in noir_wasm_testing
#2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
tom/noir-wasm-testing
branch
from
7867b88
to
be4bfc4
Compare
TomAFrench
force-pushed
the
tom/noir-wasm-testing
branch
from
be4bfc4
to
20bc4a7
Compare
TomAFrench
force-pushed
the
tom/noir-wasm-testing
branch
from
d0ffd6f
to
4f351fa
Compare
|
@jonybur Ahhhh, yeah. I forgot that the nix flake builds for a native backend by default. Good catch. Perhaps we could solve this by updating the |
|
Let's not worry about running the release acceptance tests on this. We can add these in later once we're pulling build-nargo into this repo properly. We're just hacking here. |
TomAFrench
commented
Aug 4, 2023
TomAFrench
commented
Aug 4, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
* Edit workflow * Output built directory * Fix noir_wasm copy * Fix workflow * Add mkdir to workflow * Remove logs * chore: Ensure that CLI and wasm compilers are sync in `noir_wasm_testing` (#2079) --------- Co-authored-by: jonybur <jobur93@gmail.com> * Update .github/workflows/wasm.yml * chore: run browser tests rather than nodejs tests * chore: fix test command in CI * chore: bring noir-wasm-testing repo contents into wasm crate --------- Co-authored-by: jonybur <jobur93@gmail.com> * chore: update compile command to handle not being at repo root * chore: remove unnecessary checkout * chore: update location to look for nargo binary * chore: add missing $ * chore: remove self-referential dependency * chore: switch to `noir-lang/noir-source-resolver` version which exists * chore: place downloaded wasm artifact in `crates/wasm` so it can resolve the resolver * Revisions * chore: fix CI workflow * chore: remove usage of `matrix.target` * chore: fix path to binary * chore: remove unwanted printing when compiling noir program * chore: update `Nargo.toml` to be compliant with new format * chore: remove unnecessary checkout * chore: add todo to workflow * Update .github/workflows/wasm.yml * Update crates/wasm/noir-script/src/main.nr * Update crates/wasm/test/browser/index.test.ts --------- Co-authored-by: TomAFrench <tom@tomfren.ch> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This is a pretty hacky solution to the mismatch of noirc versions between CLI and WASM. We should in future get wasm to reuse the build artifacts we have commited.
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.