Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove unused flags on LSP command #2170

Merged
merged 1 commit into from
Aug 4, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions crates/nargo_cli/src/cli/lsp_cmd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,14 @@
};
use clap::Args;
use noir_lsp::NargoLspService;
use noirc_driver::CompileOptions;
use tokio::io::BufReader;
use tower::ServiceBuilder;

use super::NargoConfig;
use crate::errors::CliError;

#[derive(Debug, Clone, Args)]
pub(crate) struct LspCommand {
#[clap(flatten)]
compile_options: CompileOptions,
}
pub(crate) struct LspCommand;

pub(crate) fn run<B: Backend>(
// Backend is currently unused, but we might want to use it to inform the lsp in the future
Expand All @@ -41,7 +37,7 @@
.service(router)
});

// Prefer truely asynchronous piped stdin/stdout without blocking tasks.

Check warning on line 40 in crates/nargo_cli/src/cli/lsp_cmd.rs

View workflow job for this annotation

GitHub Actions / Spellcheck / Spellcheck

Unknown word (truely)
#[cfg(unix)]
let (stdin, stdout) = (
async_lsp::stdio::PipeStdin::lock_tokio().unwrap(),
Expand Down