Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ssa): Merge slices in if statements with witness conditions #2347

Merged
merged 73 commits into from
Aug 18, 2023
Merged

feat(ssa): Merge slices in if statements with witness conditions #2347

merged 73 commits into from
Aug 18, 2023

Commits on Aug 9, 2023

  1. cleanup load instruction search w/ predecessors methods

    @vezenovm
    vezenovm committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    504aad0 View commit details
    Browse the repository at this point in the history

  2. update regression_2218 test

    @vezenovm
    vezenovm committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    d129a0a View commit details
    Browse the repository at this point in the history

  3. merge conflicts w/ master

    @vezenovm
    vezenovm committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    2106b6c View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. initial merge slices work, weird bug right now with intrinsics, not g… 

    …etting correct array len
    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    51abb14 View commit details
    Browse the repository at this point in the history

  2. cargo clippy

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    17d66aa View commit details
    Browse the repository at this point in the history

  3. working slice merger, but broken index_lvalue and append

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    06d7773 View commit details
    Browse the repository at this point in the history

  4. merge slices working w/ updated slice representation, have to fix som… 

    …e acir gen
    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    a92d2c9 View commit details
    Browse the repository at this point in the history

  5. clean up recursive load fetch method

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    e32e665 View commit details
    Browse the repository at this point in the history

  6. add test to mem2reg pass

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    ada6129 View commit details
    Browse the repository at this point in the history

  7. cleaner search methods

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    bedfa2a View commit details
    Browse the repository at this point in the history

  8. switch from recursive to while-loop based search for loads

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    3d422e1 View commit details
    Browse the repository at this point in the history

  9. add comments to mem2reg pass

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    c12c5bb View commit details
    Browse the repository at this point in the history

  10. fmt

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9988d91 View commit details
    Browse the repository at this point in the history

  11. remove dbg

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7cc6afe View commit details
    Browse the repository at this point in the history

  12. merge conflcits w/ mv/func-mem2reg

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    b4ee4fc View commit details
    Browse the repository at this point in the history

  13. fixed ec_baby_jubjub but need fix to mem2reg pass to make it efficient

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    24b2fe6 View commit details
    Browse the repository at this point in the history

  14. move dom tree per func

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    fc7327a View commit details
    Browse the repository at this point in the history

  15. cargo fmt

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0bb6401 View commit details
    Browse the repository at this point in the history

  16. make dom tree part of the func context

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    5baf9e8 View commit details
    Browse the repository at this point in the history

  17. merge w/ mv/func-mem2reg

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    990d593 View commit details
    Browse the repository at this point in the history

  18. remove old ocmment

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    06256c6 View commit details
    Browse the repository at this point in the history

  19. Merge branch 'mv/func-mem2reg' into mv/merge-slices-2

    @vezenovm
    vezenovm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    ae75b7a View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. fixed mem2reg before flattening

    @vezenovm
    vezenovm committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1f8d4bd View commit details
    Browse the repository at this point in the history

  2. remove loops from mem2reg function context

    @vezenovm
    vezenovm committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c8f9317 View commit details
    Browse the repository at this point in the history

  3. remove import

    @vezenovm
    vezenovm committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a824ed3 View commit details
    Browse the repository at this point in the history

  4. Update crates/noirc_evaluator/src/ssa/opt/mem2reg.rs

    @jfecher
    jfecher authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    e345f8c View commit details
    Browse the repository at this point in the history

  5. Update crates/noirc_evaluator/src/ssa/opt/mem2reg.rs

    @jfecher
    jfecher authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    fb53610 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. m em2reg debug work

    @vezenovm
    vezenovm committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    e07c999 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. working func mem2reg for various reference alias cases

    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    265b883 View commit details
    Browse the repository at this point in the history

  2. array dynamic back to original

    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    3906ca2 View commit details
    Browse the repository at this point in the history

  3. use reachable blocks

    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    7ed502d View commit details
    Browse the repository at this point in the history

  4. merge conflicts w/ master

    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    bac1e30 View commit details
    Browse the repository at this point in the history

  5. merge conflicts from master

    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d697231 View commit details
    Browse the repository at this point in the history

  6. restore sha2_blocks test

    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    71c5693 View commit details
    Browse the repository at this point in the history

  7. remove unnecessary clone and unused methods

    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    c612b45 View commit details
    Browse the repository at this point in the history

  8. merge conflcits w/ mem2reg branch and quick change

    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    4e47914 View commit details
    Browse the repository at this point in the history

  9. bring back loops check inside fetch methods

    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    ef10232 View commit details
    Browse the repository at this point in the history

  10. merge conflicts

    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    0a1925c View commit details
    Browse the repository at this point in the history

  11. Update crates/nargo_cli/tests/execution_success/regression/src/main.nr 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    8d535eb View commit details
    Browse the repository at this point in the history

  12. all to_bits methods working for acir, fixing up brillig with new slic… 

    …e structure
    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    bd678a9 View commit details
    Browse the repository at this point in the history

  13. guarantee that x == 3 in references regressio nfor 2218

    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f989fe9 View commit details
    Browse the repository at this point in the history

  14. remove leftover comments

    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    12ee7ad View commit details
    Browse the repository at this point in the history

  15. Merge branch 'mv/func-mem2reg' into mv/merge-slices-2

    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    415e516 View commit details
    Browse the repository at this point in the history

  16. all brillig sslice intrinsics working except insert and remove

    @vezenovm
    vezenovm committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    6149e48 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. working brillig_nested_slices

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    2a1da3e View commit details
    Browse the repository at this point in the history

  2. missed save

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    2a95fbf View commit details
    Browse the repository at this point in the history

  3. working brillig oracle with new slices

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c05e92c View commit details
    Browse the repository at this point in the history

  4. cleanup comments and dbgs

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    3f37004 View commit details
    Browse the repository at this point in the history

  5. merge conflicts w/ master

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    97a4b2a View commit details
    Browse the repository at this point in the history

  6. fixes to simplify_call

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c89bb76 View commit details
    Browse the repository at this point in the history

  7. cleanup updating slice length in brillig block

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    48c8514 View commit details
    Browse the repository at this point in the history

  8. cleanup in simplify_call and cleanup

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    ff631e2 View commit details
    Browse the repository at this point in the history

  9. more integration tests for merge_slices

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c55befc View commit details
    Browse the repository at this point in the history

  10. small comments

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    394b5c5 View commit details
    Browse the repository at this point in the history

  11. remove dbg

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    14b676d View commit details
    Browse the repository at this point in the history

  12. remove unnecessary noir test

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    7999996 View commit details
    Browse the repository at this point in the history

  13. remove check on failed_to_unroll

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    ffda9cc View commit details
    Browse the repository at this point in the history

  14. cleanup index_lvalue

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    9e4a065 View commit details
    Browse the repository at this point in the history

  15. cleanup codegen_literal

    @vezenovm
    vezenovm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    2b82aca View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. remove radix padding

    @vezenovm
    vezenovm committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    89e553e View commit details
    Browse the repository at this point in the history

  2. merge conflicts w/ master

    @vezenovm
    vezenovm committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    de2d962 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. some pr comments and formatting

    @vezenovm
    vezenovm committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    7ba3be5 View commit details
    Browse the repository at this point in the history

  2. Update crates/nargo_cli/tests/execution_success/brillig_to_le_bytes/s… 

    …rc/main.nr

Co-authored-by: jfecher <jake@aztecprotocol.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    caebc6b View commit details
    Browse the repository at this point in the history

  3. Update crates/noirc_evaluator/src/ssa/ir/instruction/call.rs 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    a2a0898 View commit details
    Browse the repository at this point in the history

  4. Update crates/noirc_evaluator/src/ssa/ssa_gen/mod.rs 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    5327345 View commit details
    Browse the repository at this point in the history

  5. Update crates/noirc_evaluator/src/ssa/opt/flatten_cfg.rs 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    cca2e34 View commit details
    Browse the repository at this point in the history

  6. Update crates/noirc_evaluator/src/ssa/opt/flatten_cfg.rs 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    892b435 View commit details
    Browse the repository at this point in the history

  7. Update crates/noirc_evaluator/src/ssa/ssa_gen/context.rs 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    eaa6e9c View commit details
    Browse the repository at this point in the history

  8. comments

    @vezenovm
    vezenovm committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    bfea324 View commit details
    Browse the repository at this point in the history

  9. cleanup and comments from pr review

    @vezenovm
    vezenovm committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    f8c9c70 View commit details
    Browse the repository at this point in the history

  10. more specific comment for LValue::SliceIndex assign

    @vezenovm
    vezenovm committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    b3a54c6 View commit details
    Browse the repository at this point in the history

  11. improve error in codegen_literal

    @vezenovm
    vezenovm committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    838c598 View commit details
    Browse the repository at this point in the history

  12. Update crates/noirc_evaluator/src/ssa/ssa_gen/context.rs 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    99b1c20 View commit details
    Browse the repository at this point in the history