Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Allow releases to have additional feature flags #2405

Merged
merged 4 commits into from
Aug 29, 2023
Merged

chore(ci): Allow releases to have additional feature flags #2405

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bd2b2c
feat(release): Allow releases to have additional feature flags
Maddiaa0 Aug 22, 2023
354d56e
fix: update name to extra args
Maddiaa0 Aug 24, 2023
db38371
Merge branch 'master' into md/feature-flag-release
Maddiaa0 Aug 24, 2023
f5ca546
fix: kevs recommendation
Maddiaa0 Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
tag:
description: The tag to build Nargo from (leave empty to build a nightly release from master)
required: false
features:
description: Extra feature flags to release with
required: false
publish:
description: Whether to publish the build artifacts
type: boolean
Expand Down Expand Up @@ -106,7 +109,7 @@ jobs:
env:
BARRETENBERG_BIN_DIR: ${{ github.workspace }}/libbarretenberg-wasm32/bin
run: |
cargo build --package nargo_cli --release --target ${{ matrix.target }} --no-default-features --features plonk_bn254_wasm
cargo build --package nargo_cli --release --target ${{ matrix.target }} --no-default-features --features "plonk_bn254_wasm ${{ inputs.features }}"

- uses: actions/cache/save@v3
# Don't create cache entries for the merge queue.
Expand Down Expand Up @@ -198,7 +201,7 @@ jobs:
BARRETENBERG_BIN_DIR: ${{ github.workspace }}/libbarretenberg-wasm32/bin
run: |
cargo install cross --version 0.2.5 --force
cross build --package nargo_cli --release --target=${{ matrix.target }} --no-default-features --features plonk_bn254_wasm
cross build --package nargo_cli --release --target=${{ matrix.target }} --no-default-features --features "plonk_bn254_wasm ${{ inputs.features }}"

- uses: actions/cache/save@v3
# Don't create cache entries for the merge queue.
Expand Down Expand Up @@ -282,7 +285,7 @@ jobs:
env:
BARRETENBERG_BIN_DIR: ${{ github.workspace }}/libbarretenberg-wasm32/bin
run: |
cargo build --package nargo_cli --release --target ${{ matrix.target }} --no-default-features --features plonk_bn254_wasm
cargo build --package nargo_cli --release --target ${{ matrix.target }} --no-default-features --features "plonk_bn254_wasm ${{ inputs.features }}"

- uses: actions/cache/save@v3
# Don't create cache entries for the merge queue.
Expand Down
Loading