Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add test(should_fail) attribute for tests that are meant to fail #2418

Merged
merged 35 commits into from
Aug 24, 2023
Merged

feat: Add test(should_fail) attribute for tests that are meant to fail #2418

merged 35 commits into from
Aug 24, 2023

Commits on Aug 23, 2023

  1. test(should_fail)

    @Ethan-000
    Ethan-000 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    04f20b9 View commit details
    Browse the repository at this point in the history

  2. update comment

    @Ethan-000
    Ethan-000 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d684879 View commit details
    Browse the repository at this point in the history

  3. make only unsatisfied constraint success

    @Ethan-000
    Ethan-000 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b8dc4f5 View commit details
    Browse the repository at this point in the history

  4. testfunc type alias to replace tuple

    @Ethan-000
    Ethan-000 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    54137b1 View commit details
    Browse the repository at this point in the history

  5. inline comment

    @Ethan-000
    Ethan-000 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    5ee5dfb View commit details
    Browse the repository at this point in the history

  6. change to expect failure

    @Ethan-000
    Ethan-000 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    2268b1e View commit details
    Browse the repository at this point in the history

  7. change Test(bool) to Test{}

    @Ethan-000
    Ethan-000 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    4c5145f View commit details
    Browse the repository at this point in the history

  8. clippy

    @Ethan-000
    Ethan-000 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    4bd422e View commit details
    Browse the repository at this point in the history

  9. remove duplication

    @Ethan-000
    Ethan-000 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    09b0799 View commit details
    Browse the repository at this point in the history

  10. remove duplication

    @Ethan-000
    Ethan-000 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    148ab5c View commit details
    Browse the repository at this point in the history

  11. remove duplication

    @Ethan-000
    Ethan-000 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f165f48 View commit details
    Browse the repository at this point in the history

  12. add some spacing

    @Ethan-000
    Ethan-000 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    52ca47f View commit details
    Browse the repository at this point in the history

  13. Update crates/noirc_frontend/src/hir/resolution/resolver.rs 

    Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
    @Ethan-000 @phated
    Ethan-000 and phated authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    131eec5 View commit details
    Browse the repository at this point in the history

  14. Update crates/noirc_frontend/src/hir/def_map/mod.rs 

    Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
    @Ethan-000 @phated
    Ethan-000 and phated authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    83a281e View commit details
    Browse the repository at this point in the history

  15. make testfunc a struct

    @Ethan-000
    Ethan-000 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f550b30 View commit details
    Browse the repository at this point in the history

  16. fix typo

    @Ethan-000
    Ethan-000 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    a0c3771 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. rename testfunc to testfunction

    @Ethan-000
    Ethan-000 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    34f3af7 View commit details
    Browse the repository at this point in the history

  2. only pass in test function

    @Ethan-000
    Ethan-000 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    0a33986 View commit details
    Browse the repository at this point in the history

  3. Update crates/nargo_cli/src/cli/test_cmd.rs 

    Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
    @Ethan-000 @phated
    Ethan-000 and phated authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    aa1a719 View commit details
    Browse the repository at this point in the history

  4. use pattern matching

    @Ethan-000
    Ethan-000 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    d741ef3 View commit details
    Browse the repository at this point in the history

  5. use a single filtermap untested

    @Ethan-000
    Ethan-000 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    49bd10a View commit details
    Browse the repository at this point in the history

  6. clippy

    @Ethan-000
    Ethan-000 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    3d96f3f View commit details
    Browse the repository at this point in the history

  7. use if le

    @Ethan-000
    Ethan-000 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    77d9c33 View commit details
    Browse the repository at this point in the history

  8. Update crates/noirc_frontend/src/hir/def_map/mod.rs 

    Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
    @Ethan-000 @phated
    Ethan-000 and phated authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    9d55fbf View commit details
    Browse the repository at this point in the history

  9. chore: use general scope variant instead of expect_failure (#2427)

    @kevaundray
    kevaundray authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    8f8106a View commit details
    Browse the repository at this point in the history

  10. fix clippy

    @Ethan-000
    Ethan-000 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    74ef56f View commit details
    Browse the repository at this point in the history

  11. use cfg test to fix clippy

    @Ethan-000
    Ethan-000 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a49655d View commit details
    Browse the repository at this point in the history

  12. Update crates/nargo_cli/src/cli/test_cmd.rs 

    Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
    @Ethan-000 @phated
    Ethan-000 and phated authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    cb36da0 View commit details
    Browse the repository at this point in the history

  13. rename function to should_fail

    @Ethan-000
    Ethan-000 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    d1188a2 View commit details
    Browse the repository at this point in the history

  14. fix clippy by putting a cfg on mod tests

    @kevaundray
    kevaundray committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    6cddf30 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'e/should_panic' of github.com:noir-lang/noir into e/sho… 

    …uld_panic
    @kevaundray
    kevaundray committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    53d4bdf View commit details
    Browse the repository at this point in the history

  16. Merge branch 'e/should_panic' of github.com:noir-lang/noir into e/sho… 

    …uld_panic
    @kevaundray
    kevaundray committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    f1ff2ad View commit details
    Browse the repository at this point in the history

  17. add comments

    @kevaundray
    kevaundray committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    8b26cb8 View commit details
    Browse the repository at this point in the history

  18. write error with color

    @Ethan-000
    Ethan-000 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    239484f View commit details
    Browse the repository at this point in the history

  19. add more comments regarding programs that are never satisfiable

    @kevaundray
    kevaundray committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    095741b View commit details
    Browse the repository at this point in the history