Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error message for InternalError #2429

Merged
merged 1 commit into from Aug 24, 2023
Merged

chore: improve error message for InternalError #2429

merged 1 commit into from Aug 24, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 24, 2023

Description

improve error message for InternalError

Problem

Resolves #2386 (comment)

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher enabled auto-merge August 24, 2023 18:24
@jfecher jfecher added this pull request to the merge queue Aug 24, 2023
Merged via the queue into noir-lang:master with commit ff62377 Aug 24, 2023
16 checks passed
TomAFrench added a commit that referenced this pull request Aug 24, 2023
* master:
  chore: improve error message for InternalError (#2429)
  chore: Add stdlib to every crate as it is added to graph (#2392)
  feat: create equivalence relationships for intermediate witnesses from multiplication (#2414)
  chore(ci): Fix version of `cross` to 0.2.5 (#2426)
  fix: Correct off-by-one errors in lexer spans (#2393)
TomAFrench added a commit that referenced this pull request Aug 25, 2023
* master:
  fix: Implement new mem2reg pass (#2420)
  feat(nargo): Support optional directory in git dependencies (#2436)
  fix(acir_gen): Pass accurate contents to slice inputs for bb func calls (#2435)
  fix(ssa): codegen missing check for unary minus (#2413)
  fix(lsp): Remove duplicated creation of lenses (#2433)
  feat: Add `test(should_fail)` attribute for tests that are meant to fail (#2418)
  chore: improve error message for InternalError (#2429)
  chore: Add stdlib to every crate as it is added to graph (#2392)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant