Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): fixes for the parsing of 'where' clauses #2430

Merged
merged 12 commits into from
Aug 28, 2023
Merged

fix(parser): fixes for the parsing of 'where' clauses #2430

merged 12 commits into from
Aug 28, 2023

Commits on Aug 24, 2023

  1. fix(parser): first item in a where clause must be an identifier, not … 

    …a type
    @nickysn
    nickysn committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    2f8d7bb View commit details
    Browse the repository at this point in the history

  2. fix(parser): support trait constraints with multiple and/or generic t… 

    …raits
    @nickysn
    nickysn committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    0f56339 View commit details
    Browse the repository at this point in the history

  3. refactor(parser): where_trait_bounds() renamed trait_bounds() 

    The parser function where_trait_bounds() was renamed trait_bounds().

Rationale: The same function can later be used for parsing 'impl TraitX+TraitY'
as function parameters or return values. They contain trait bounds, without
using the keyword 'where'.

No functional changes.
    @nickysn
    nickysn committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    1f00ea6 View commit details
    Browse the repository at this point in the history

  4. refactor(parser): where_trait_bound() renamed trait_bound() 

    The function where_trait_bound was renamed trait_bound.

Rationale: Same as previous commit.

No functional changes.
    @nickysn
    nickysn committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    d381599 View commit details
    Browse the repository at this point in the history

  5. fix: don't display empty generic trait bounds as '<>'

    @nickysn
    nickysn committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    10d667d View commit details
    Browse the repository at this point in the history

  6. fix(parser): print the where clause in function definitions

    @nickysn
    nickysn committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    f900f34 View commit details
    Browse the repository at this point in the history

  7. refactor(parser): use !is_empty() instead of len()>0

    @nickysn
    nickysn committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    2e7b590 View commit details
    Browse the repository at this point in the history

  8. fix(parser): again allow any type on the left side of the ':' in the … 

    …where clause
    @nickysn
    nickysn committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a95e10c View commit details
    Browse the repository at this point in the history

  9. test(parser): added test for several comma-separated conditions in th… 

    …e where clause
    @nickysn
    nickysn committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    7abdc1e View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. refactor(parser): simplify the TraitConstraint structure 

    Simplify the TraitConstraint structure by making it hold only a single trait
bound, instead of a vector of trait bounds. Previously, the vector would
represent constraints, containing multiple traits, concatenated with '+', such
as 'where Foo: Display + TraitX + TraitY<U, V>'. Now this is simplified in the
parser to several constraints, containing only a single bound:
  'Foo: Display',
  'Foo: TraitX',
  'Foo: TraitY<U, V>'
    @nickysn
    nickysn committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    fd489e1 View commit details
    Browse the repository at this point in the history

  2. refactor(parser): use !generics.is_empty() instead of generics.len()>0

    @nickysn
    nickysn committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    cbf7c23 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'noir-lang:master' into nickysn/parser_fixes_for_where_c… 

    …lause
    @nickysn
    nickysn authored Aug 26, 2023
    Configuration menu
    Copy the full SHA
    d4ac54b View commit details
    Browse the repository at this point in the history