Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable dynamic indices on slices #2446

Merged
merged 58 commits into from
Sep 7, 2023
Merged

feat: Enable dynamic indices on slices #2446

merged 58 commits into from
Sep 7, 2023

Commits on Aug 22, 2023

  1. initial work for get dynamic indexing for slices working

    @vezenovm
    vezenovm committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    1f9c258 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mv/slice-dyn-index

    @vezenovm
    vezenovm committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    0c79421 View commit details
    Browse the repository at this point in the history

  3. Add everything except alias handling

    @jfecher
    jfecher committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    78c1921 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Fix all tests

    @jfecher
    jfecher committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    49cc0c8 View commit details
    Browse the repository at this point in the history

  2. clippy

    @jfecher
    jfecher committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    88913c1 View commit details
    Browse the repository at this point in the history

  3. initial work to get dyn slices working

    @vezenovm
    vezenovm committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    079ea08 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'jf/new-mem2reg' into mv/slice-dyn-index

    @vezenovm
    vezenovm committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0619ad7 View commit details
    Browse the repository at this point in the history

  5. merged in jf/new-mem2reg, have partial dynamic indices support but ca… 

    …nnot merge a load
    @vezenovm
    vezenovm committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    4f22d7b View commit details
    Browse the repository at this point in the history

  6. debug comment

    @vezenovm
    vezenovm committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    fb77dfa View commit details
    Browse the repository at this point in the history

  7. Mild cleanup

    @jfecher
    jfecher committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    8804a3f View commit details
    Browse the repository at this point in the history

  8. Undo some unneeded changes

    @jfecher
    jfecher committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    cd29ec8 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Partially revert cleanup commit which broke some tests

    @jfecher
    jfecher committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    f3f34aa View commit details
    Browse the repository at this point in the history

  2. Add large doc comment

    @jfecher
    jfecher committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    0887db5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into jf/new-mem2reg

    @jfecher
    jfecher committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a8a3f36 View commit details
    Browse the repository at this point in the history

  4. Add test and remove printlns

    @jfecher
    jfecher committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    33feb07 View commit details
    Browse the repository at this point in the history

  5. Remove todos

    @jfecher
    jfecher committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    2574c33 View commit details
    Browse the repository at this point in the history

  6. working dynamic slice indices w/ slice push back, need to still clean… 

    …up and add other dnyamic slice intrinsics
    @vezenovm
    vezenovm committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    96b9469 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'jf/new-mem2reg' into mv/slice-dyn-index

    @vezenovm
    vezenovm committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    240eedb View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. adding slice insert to get_slice_length in flattening, need to rework… 

    … method
    @vezenovm
    vezenovm committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    cd8cf41 View commit details
    Browse the repository at this point in the history

  2. remove comment from slice push back

    @vezenovm
    vezenovm committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    876bde8 View commit details
    Browse the repository at this point in the history

  3. working dynamic slices except for insert and remove

    @vezenovm
    vezenovm committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    d3dbffa View commit details
    Browse the repository at this point in the history

  4. remove old get_slice_length method

    @vezenovm
    vezenovm committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    c44321b View commit details
    Browse the repository at this point in the history

  5. some cleanup

    @vezenovm
    vezenovm committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    d7bf169 View commit details
    Browse the repository at this point in the history

  6. conflicts w/ master

    @vezenovm
    vezenovm committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    7c17c62 View commit details
    Browse the repository at this point in the history

  7. cargo clippy and fmt 

    git status
    @vezenovm
    vezenovm committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    b60e23c View commit details
    Browse the repository at this point in the history

  8. remove commented out patch from cargo toml

    @vezenovm
    vezenovm committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    c672088 View commit details
    Browse the repository at this point in the history

  9. fix how we resolve length for slice intrinsics in flattening

    @vezenovm
    vezenovm committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    25d21b4 View commit details
    Browse the repository at this point in the history

  10. bring back full slice test

    @vezenovm
    vezenovm committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    a1adca3 View commit details
    Browse the repository at this point in the history

  11. uncomment slices test

    @vezenovm
    vezenovm committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    3749b90 View commit details
    Browse the repository at this point in the history

  12. remove unnecessary assert that was for testing

    @vezenovm
    vezenovm committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    3b7ef52 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Merge branch 'master' into mv/slice-dyn-index

    @vezenovm
    vezenovm committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    71b01a2 View commit details
    Browse the repository at this point in the history

  2. fix outer block stores in flattening

    @vezenovm
    vezenovm committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    5c30a44 View commit details
    Browse the repository at this point in the history

  3. cargo fmt

    @vezenovm
    vezenovm committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7fb1b11 View commit details
    Browse the repository at this point in the history

  4. move regression_dynamic_slice_index to new project

    @vezenovm
    vezenovm committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    cdfa36b View commit details
    Browse the repository at this point in the history

  5. switch to var_to_expression and remove get_constant method

    @vezenovm
    vezenovm committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d0dded9 View commit details
    Browse the repository at this point in the history

  6. slcie insert and remove with constant index

    @vezenovm
    vezenovm committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    347e9a6 View commit details
    Browse the repository at this point in the history

  7. add comments for issues

    @vezenovm
    vezenovm committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    681d3e9 View commit details
    Browse the repository at this point in the history

  8. Empty-Commit

    @vezenovm
    vezenovm committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9b95a3a View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into mv/slice-dyn-index

    @vezenovm
    vezenovm committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c0094df View commit details
    Browse the repository at this point in the history

  10. fix constant folding optimization and cargo fmt

    @vezenovm
    vezenovm committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e067884 View commit details
    Browse the repository at this point in the history

  11. refactor handle array operation

    @vezenovm
    vezenovm committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d093f19 View commit details
    Browse the repository at this point in the history

  12. cargo clipy

    @vezenovm
    vezenovm committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    6e4f75a View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. remove assert in slice_dynamic_index_test

    @vezenovm
    vezenovm committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    15c79e0 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. master merge

    @vezenovm
    vezenovm committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    14849e1 View commit details
    Browse the repository at this point in the history

  2. remove old debug derive

    @vezenovm
    vezenovm committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    1ad7de0 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. add assert constant in slice insert and remove

    @vezenovm
    vezenovm committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    39fee20 View commit details
    Browse the repository at this point in the history

  2. fix brillig slices

    @vezenovm
    vezenovm committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    8afe885 View commit details
    Browse the repository at this point in the history

  3. master conflcits

    @vezenovm
    vezenovm committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    1d0c822 View commit details
    Browse the repository at this point in the history

  4. pass correct inputs for recursive aggregation but we need to most lik… 

    …ely simulate recursion again
    @vezenovm
    vezenovm committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    e6d7aa8 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Merge branch 'master' into mv/slice-dyn-index

    @vezenovm
    vezenovm committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    c38e873 View commit details
    Browse the repository at this point in the history

  2. merge conflicts

    @vezenovm
    vezenovm committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    395e79c View commit details
    Browse the repository at this point in the history

  3. use default after fxHashMap

    @vezenovm
    vezenovm committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    dc2defb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into mv/slice-dyn-index

    @vezenovm
    vezenovm committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    6446e86 View commit details
    Browse the repository at this point in the history

  5. fix call_black_box for recursive agg

    @vezenovm
    vezenovm committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    cbf6f36 View commit details
    Browse the repository at this point in the history

  6. cleanup printer and cargo fmt

    @vezenovm
    vezenovm committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    a14f9f3 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. remove assert_constant case from brillig_block

    @vezenovm
    vezenovm committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    2c695e3 View commit details
    Browse the repository at this point in the history

  2. remove arguments.len() check in simplify_call ArrayLen

    @vezenovm
    vezenovm committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    1e346be View commit details
    Browse the repository at this point in the history

  3. add test for using push back on dyn slice outside of if statement

    @vezenovm
    vezenovm committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    576b15c View commit details
    Browse the repository at this point in the history