Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): enforce clippy and cargo fmt in CI #2628

Merged
merged 4 commits into from
Sep 11, 2023
Merged

chore(ci): enforce clippy and cargo fmt in CI #2628

merged 4 commits into from
Sep 11, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This was removed as part of getting dynamic backends merged into this repository as these checks we performed within the nix flake. This PR re-adds these checks.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench changed the title chore: enforce clippy and cargo fmt in CI chore(ci): enforce clippy and cargo fmt in CI Sep 11, 2023
kobyhallx
kobyhallx previously approved these changes Sep 11, 2023
@kobyhallx kobyhallx added this pull request to the merge queue Sep 11, 2023
@TomAFrench TomAFrench removed this pull request from the merge queue due to a manual request Sep 11, 2023
@kevaundray kevaundray added this pull request to the merge queue Sep 11, 2023
Merged via the queue into master with commit e54cf10 Sep 11, 2023
14 checks passed
@kevaundray kevaundray deleted the clippy-ci branch September 11, 2023 13:34
TomAFrench added a commit that referenced this pull request Sep 11, 2023
* master:
  chore: Move tooling related items into their own directory (#2644)
  chore: add `CompilationResult` helper type (#2639)
  fix: initialise arrays returned by brillig (#2048)
  chore: clippy fix (#2631)
  fix(wasm): Remove stacker from dependencies (#2637)
  chore(ci): reenable CI for `noir_wasm` (#2636)
  fix: avoid overflows in integer division (#2180)
  chore(ci): Nightly Integration testing  (#2596)
  feat(parser): allow multiple attributes (#2537)
  feat(nargo): Allow installing custom backends from the CLI (#2632)
  chore(ci): enforce clippy and `cargo fmt` in CI (#2628)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants