Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssa): Do not replace previously constrained values #2647

Merged
merged 15 commits into from
Sep 21, 2023
Merged

fix(ssa): Do not replace previously constrained values #2647

merged 15 commits into from
Sep 21, 2023

Commits on Sep 11, 2023

  1. do not simplify ArrayLen for slices in SSA

    @vezenovm
    vezenovm committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a4f3b78 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. do not replace constrained values with side effects enabled

    @vezenovm
    vezenovm committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0fc0075 View commit details
    Browse the repository at this point in the history

  2. add test to constant_folding and fix up slices integration test

    @vezenovm
    vezenovm committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    6566b27 View commit details
    Browse the repository at this point in the history

  3. remove old comment

    @vezenovm
    vezenovm committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    d871f8b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into mv/slice-len-check-fix

    @vezenovm
    vezenovm committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    36f8cc1 View commit details
    Browse the repository at this point in the history

  5. return match directly

    @vezenovm
    vezenovm committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    70e8744 View commit details
    Browse the repository at this point in the history

  6. Update compiler/noirc_evaluator/src/ssa/opt/constant_folding.rs 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    @vezenovm @TomAFrench
    vezenovm and TomAFrench authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0b0395a View commit details
    Browse the repository at this point in the history

  7. deref bool earlier

    @vezenovm
    vezenovm committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    779d20e View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Update compiler/noirc_evaluator/src/ssa/opt/constant_folding.rs

    @kevaundray
    kevaundray authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    682c5bb View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. merge conflcits w/ master

    @vezenovm
    vezenovm committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    af1b4a0 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Merge branch 'master' into mv/slice-len-check-fix

    @vezenovm
    vezenovm committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    f8b8cde View commit details
    Browse the repository at this point in the history

  2. Update compiler/noirc_evaluator/src/ssa/opt/constant_folding.rs 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    097a275 View commit details
    Browse the repository at this point in the history

  3. remove constrain_cache in constant_folding

    @vezenovm
    vezenovm committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    deec30c View commit details
    Browse the repository at this point in the history

  4. move len checks to be first one

    @vezenovm
    vezenovm committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    a47ce03 View commit details
    Browse the repository at this point in the history

  5. correct slice len assertion

    @vezenovm
    vezenovm committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    20a1b7e View commit details
    Browse the repository at this point in the history