chore: defer reporting of errors until after compilation and optimization is finished #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
tf/defer-compilation-warnings
branch
from
9973acc
to
96344bc
Compare
TomAFrench
force-pushed
the
tf/defer-compilation-warnings
branch
from
96344bc
to
224bc48
Compare
5 tasks
kevaundray
approved these changes
Sep 12, 2023
TomAFrench
added a commit
that referenced
this pull request
Sep 12, 2023
* master: chore: defer reporting of errors until after compilation and optimization is finished (#2659)
TomAFrench
added a commit
that referenced
this pull request
Sep 13, 2023
* master: chore: fix npm token for abi_wasm publishing (#2633) chore(ci): switch to using `Swatinem/rust-cache` action (#2671) feat: compile circuits and query circuit sizes in parallel for `nargo info` (#2665) chore(ci): use mock backend for all tests (#2670) chore!: Restrict packages to contain at most a single contract (#2668) chore: Embed a file map into `CompiledProgram`/`CompiledContract` (#2666) feat: Compile workspace packages in parallel (#2612) fix(wasm): Avoid requesting stdlib paths from the source-resolver (#2650) chore: add abi_wasm to release-please (#2664) chore: refactor `execute_cmd` (#2656) chore: defer reporting of errors until after compilation and optimization is finished (#2659) fix: fix compilation using `aztec` feature flag (#2663) fix: remove duplicate file extension in stack trace (#2655) chore: use `DebugArtifact`s instead of `FileManager` to report errors (#2641) chore: Fix clippy warnings for rust version 1.67.0 (#2661) fix(wasm): Apply transformation map to circuit debug information in `noir_wasm` (#2635) fix: Fix `update_acir` deleting all debug information (#2643)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Progress towards #2613
Summary*
This PR reworks
compile_contractsandcompile_packageso that they return aCompilationResult<T>. This means that they no longer report their errors/warnings as soon as they can, but delegate this tocompile_cmd::run. This is useful for #2613 as we can now construct two vectors ofCompilationResult<T>(one for programs, one for contracts) in parallel and then simply iterate through them to print out the warnings/errors safely.The file manager is leaking again as we need to getThis would require us to have a debug artifact for a failed compilation which seems uglier in my mind. We should probably maintain the usage ofreport_all_errorsto pick up the debug artifacts.FileManagerfor compilation errors and just useDebugArtifactfor execution errors.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.