Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix noirc_abi_wasm publish for release-please #2699

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Sep 14, 2023

Description

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

kobyhallx
kobyhallx previously approved these changes Sep 14, 2023
Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonybur jonybur marked this pull request as ready for review September 14, 2023 15:36
kobyhallx
kobyhallx previously approved these changes Sep 14, 2023
Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomAFrench TomAFrench changed the title chore: fix abi_wasm publish for release-please chore: fix noirc_abi_wasm publish for release-please Sep 14, 2023
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to publish a lot of redundant versions but LGTM.

@TomAFrench TomAFrench added this pull request to the merge queue Sep 14, 2023
Merged via the queue into master with commit 8d464a6 Sep 14, 2023
15 checks passed
@TomAFrench TomAFrench deleted the jb-relase-please-fix branch September 14, 2023 16:52
TomAFrench added a commit that referenced this pull request Sep 15, 2023
* tf/split-build-and-test:
  chore: remove reference to `result` directory
  chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718)
  chore: clippy fixes (#2719)
  chore: fix version querying
  chore: nits
  chore(ci): fix playwright caching
  chore: pass full `package.json` into build artifact
  chore: clean up straggler `packageManager`
  chore: remove `packageManager" fields from workspace packages
  chore: refresh lockfile
  Update .github/workflows/abi_wasm.yml
  chore: split build and tests jobs in `abi_wasm.yml`
  chore: Integrate noir.js into workspace and CI release workflow (#2705)
  feat: Add initial version of noir.js (#2681)
  chore: switch `release-source-resolver.yml` to use yarn (#2704)
  chore: move stranded test to correct directory (#2701)
  chore(ci): deny wildcard dependencies (#2702)
  chore: fix `noirc_abi_wasm` publish for release-please (#2699)
TomAFrench added a commit that referenced this pull request Sep 15, 2023
* master:
  chore: Add deprecation message for default type in for loop (#2689)
  chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718)
  chore: clippy fixes (#2719)
  chore: Integrate noir.js into workspace and CI release workflow (#2705)
  feat: Add initial version of noir.js (#2681)
  chore: switch `release-source-resolver.yml` to use yarn (#2704)
  chore: move stranded test to correct directory (#2701)
  chore(ci): deny wildcard dependencies (#2702)
  chore: fix `noirc_abi_wasm` publish for release-please (#2699)
  chore: introduce workspace for js packages (#2677)
  feat: Allow methods defined in a contract to be non-entry points (#2687)
  chore: revert some unwanted small changes from PR2180 (#2685)
  feat(lsp): Add nargo capabilities for test metadata (#2532)
  chore(ci): Add `cargo deny` workflow (#2682)
TomAFrench added a commit that referenced this pull request Sep 15, 2023
* master:
  chore(ci): Treat clippy warnings as errors in CI (#2684)
  chore(ci): Cache yarn and playwright dependencies in CI (#2697)
  chore: Add noir-wasm publishing as a workflow (#2721)
  fix: failing js tests (#2722)
  chore: Add deprecation message for default type in for loop (#2689)
  chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718)
  chore: clippy fixes (#2719)
  chore: Integrate noir.js into workspace and CI release workflow (#2705)
  feat: Add initial version of noir.js (#2681)
  chore: switch `release-source-resolver.yml` to use yarn (#2704)
  chore: move stranded test to correct directory (#2701)
  chore(ci): deny wildcard dependencies (#2702)
  chore: fix `noirc_abi_wasm` publish for release-please (#2699)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants