-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): split build and tests jobs in abi_wasm.yml
#2714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
tf/split-build-and-test
branch
from
September 15, 2023 10:33
391e91a
to
9d9c947
Compare
kevaundray
reviewed
Sep 15, 2023
5 tasks
I've found the underlying cause for this issue. When we were downloading the artifact, we were overwriting the package.json with the one from the build outputs. This had some fields filtered out of it which resulted in the yarn behaviour. |
Oof, requested review too soon. |
TomAFrench
force-pushed
the
tf/split-build-and-test
branch
from
September 15, 2023 14:52
f2cf2ea
to
9647178
Compare
kevaundray
reviewed
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Summary*
This separates the building and testing of
noirc_abi_wasm
which, among other things, allows easier rerunning in the case of a flakey test failure.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.