chore: split 9_conditional test case and remove 8_integration #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
approved these changes
Sep 19, 2023
jfecher
changed the title
TomAFrench
added a commit
that referenced
this pull request
Sep 20, 2023
* master: feat(traits): Type checking for Trait impl method signatures (#2652) chore: split 9_conditional test case and remove 8_integration (#2751) chore(github): Add "Idea Action Plan" Issue template (#2736) feat(aztec-noir): abstract storage (#2750) feat: signed arithmetic (#2748) chore: encapsulate abstraction leaks from `bb` into new crate (#2747) feat: Variable liveness analysis for brillig (#2715) chore: noirjs integration testing (#2744) chore: Add rust-toolchain file & adapt nix for changes (#2686) chore: wrap backend info response in a struct instead of boxed closure (#2737) fix: check for literal overflows in expressions (#2742) fix: nightly js test (#2740) fix: keep the correct type for bitshift (#2739) chore: Make new daily nightly releases be pre-releases and non latest (#2735) chore: disabling display location section (#2118) chore: add a workflow that tracks acvm version for integration tests (#2700) feat: Save nightly build in github releases with date tags (#2416) chore: Add unified linting setup for JS code and enforce in CI (#2728)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes 8_integration test case, which is superseded by sha2_byte
Replaces 9_conditional by smaller conditional_1, conditional_2 and conditional_3_regression
Problem*
Resolves #1928
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.