Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(traits): multi module support for traits #2844

Merged
merged 18 commits into from
Sep 29, 2023
Merged

feat(traits): multi module support for traits #2844

merged 18 commits into from
Sep 29, 2023

Commits on Sep 26, 2023

  1. feat(traits): multi module support for traits 

    This adds initial module support for traits. It's now allowed for
traits, impl blocks & the type definitions to reside in different
modules or crates.

Co-authored-by: Alex Vitkov <alexvitkov98@gmail.com>
    @nickysn @alexvitkov
    nickysn and alexvitkov committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    78cff10 View commit details
    Browse the repository at this point in the history

  2. fix(traits): cleanup, fmt

    @alexvitkov @nickysn
    alexvitkov authored and nickysn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    10e42c5 View commit details
    Browse the repository at this point in the history

  3. fix(traits): remove redundant code

    @alexvitkov @nickysn
    alexvitkov authored and nickysn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    3c6c4a4 View commit details
    Browse the repository at this point in the history

  4. fix(traits): remove object_type_span

    @alexvitkov @nickysn
    alexvitkov authored and nickysn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    aa77ec6 View commit details
    Browse the repository at this point in the history

  5. fix(traits): correct order of UnresolvedTraitImpl::methods

    @alexvitkov @nickysn
    alexvitkov authored and nickysn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    76d086e View commit details
    Browse the repository at this point in the history

  6. test(traits): add test for trait with many methods

    @alexvitkov @nickysn
    alexvitkov authored and nickysn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    37db4cd View commit details
    Browse the repository at this point in the history

  7. chore(traits): added comment with TODO. No functional changes.

    @nickysn
    nickysn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    d656927 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into traits-modules-support-r3

    @nickysn
    nickysn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    3664e37 View commit details
    Browse the repository at this point in the history

  9. style(traits): fix cargo fmt error

    @nickysn
    nickysn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    cb2f0f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. chore(traits): store Trait instead of Shared<Trait>

    @alexvitkov
    alexvitkov committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    6765477 View commit details
    Browse the repository at this point in the history

  2. chore(traits): remove defined_functions

    @alexvitkov
    alexvitkov committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    58d545f View commit details
    Browse the repository at this point in the history

  3. fix(traits): removed duplicated code, added accidentally during merge… 

    … conflict resolution
    @nickysn
    nickysn committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    bee0f58 View commit details
    Browse the repository at this point in the history

  4. refactor(traits): extracted method collect_trait_impl. No functional … 

    …changes.
    @nickysn
    nickysn committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    8e1d8dd View commit details
    Browse the repository at this point in the history

  5. Fix PR commit with simplification

    @ymadzhunkov
    ymadzhunkov committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    dcffa07 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Try to simplify collect_trait_impl

    @ymadzhunkov
    ymadzhunkov committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    db7909a View commit details
    Browse the repository at this point in the history

  2. More simplification

    @ymadzhunkov
    ymadzhunkov committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    7826249 View commit details
    Browse the repository at this point in the history

  3. fix(traits): dont use paths to check for crate

    @alexvitkov @ymadzhunkov
    alexvitkov authored and ymadzhunkov committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    b8b9a81 View commit details
    Browse the repository at this point in the history

  4. Apply cargo fmt --all

    @ymadzhunkov
    ymadzhunkov committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    0231aae View commit details
    Browse the repository at this point in the history