chore(ci): rename CI workflows based on theme #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
kevaundray
approved these changes
Sep 26, 2023
|
Merging this through as there seems to be a bug/unwanted feature in the workflow dispatch code where, if you try to dispatch a workflow named "publish.yml" , it will also match on "ccvm-publish.yml" The relevant LOC is here |
TomAFrench
added a commit
that referenced
this pull request
Sep 27, 2023
* master: (40 commits) chore(noir): Release (master) (#2859) chore: remove rebuild script since its failing chore(ci): rename CI workflows based on theme (#2853) chore(noir): Release (master) (#2827) chore: add solidity verifier workflow (#2749) chore: add `CRS` directory to gitignore (#2852) chore: add initial version of `Backend` interface for `noir_js` (#2851) chore(errors): Refactor errors representation in compiler (#2760) chore(ci): run `noir_js` tests in CI (#2843) chore(noir_js)!: Rename inner and outer proof methods (#2845) chore: remove unnecessary `AcirValue`s (#2823) fix: Conditionally run the "Create or Update PR" step in acir artifacts rebuild workflow (#2849) fix: lack of cjs package version (#2848) chore: delete unnecessary nix files (#2840) chore!: `generateWitness` now returns a serialized witness file (#2842) chore: fix `acvm_js` linting and tests (#2834) feat: remove redundant predicate from brillig quotients (#2784) chore: Fix dependencies in acvm_js and remove local lock file (#2833) chore: add acvm_js to integration build chore: update discord link (#2831) ...
TomAFrench
added a commit
that referenced
this pull request
Sep 28, 2023
* master: (107 commits) chore: remove leftover files from `acvm-repo` (#2861) chore: miscellaneous ACVM fixups (#2864) chore(noir): Release (master) (#2875) fix: Remove cast for field comparisons in brillig (#2874) fix: remove duplication of code to load stdlib files (#2868) chore(noir_js): remove unnecessary input validation in JS (#2841) chore: build yarn packages in parallel (#2867) chore(ci): remove `toml2json` dependency (#2862) chore: fix infinite loop in yarn workspace cleaning (#2863) chore(noir): Release (master) (#2859) chore: remove rebuild script since its failing chore(ci): rename CI workflows based on theme (#2853) chore(noir): Release (master) (#2827) chore: add solidity verifier workflow (#2749) chore: add `CRS` directory to gitignore (#2852) chore: add initial version of `Backend` interface for `noir_js` (#2851) chore(errors): Refactor errors representation in compiler (#2760) chore(ci): run `noir_js` tests in CI (#2843) chore(noir_js)!: Rename inner and outer proof methods (#2845) chore: remove unnecessary `AcirValue`s (#2823) ...
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR renames the workflow files based on their theme to group together workflows which can later be merged.
publish-*.yml: builds and publishes an artifact to npm/crates.io/github releasetest-*.yml: runs tests on a package.I've also renamed
pull-request.ymltopull-request-title.ymlto make it clearer that it's just related to the pull request title rather than a workflow which handles all pull request checks.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.