chore: add standard linting setup to all crates #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
added a commit
that referenced
this pull request
Sep 29, 2023
* master: chore: refactor integration test (#2901) feat(acvm_js): export black box solver functions (#2812) chore: add standard linting setup to all crates (#2900) chore: use Noir number in release PR (#2905) chore: clippy fixes (#2897) chore: use workspace rust version in `backend-interface` crate (#2896)
TomAFrench
added a commit
that referenced
this pull request
Sep 29, 2023
* master: chore: refactor integration test (#2901) feat(acvm_js): export black box solver functions (#2812) chore: add standard linting setup to all crates (#2900) chore: use Noir number in release PR (#2905) chore: clippy fixes (#2897) chore: use workspace rust version in `backend-interface` crate (#2896)
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
A number of crates didn't have our standard linting setup so I've added it and fixed all the warnings. As a result of this I've removed a number of unnecessary dependencies.
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.