Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): replace webdriver with playwright #2988

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @web/test-runner-webdriver@0.7.0

@TomAFrench TomAFrench marked this pull request as ready for review October 4, 2023 16:55
@kevaundray kevaundray added this pull request to the merge queue Oct 4, 2023
@TomAFrench
Copy link
Member Author

I decided to go down this route rather than webdriver as it seems to work on more systems and matches what is being used in aztec-packages.

Merged via the queue into master with commit f203161 Oct 4, 2023
26 checks passed
@kevaundray kevaundray deleted the tf/playwright branch October 4, 2023 17:15
TomAFrench added a commit that referenced this pull request Oct 6, 2023
* master: (31 commits)
  chore: run tests for `noir_wasm` in node under default resolver (#3020)
  chore: align versions for js packages (#3019)
  fix: Fix aztec library after nargo fmt (#3014)
  chore: simplify ES workspace build and publish (#2989)
  fix: fix method `program_counter`, change method signature (#3012)
  fix: ACIR optimizer should update assertion messages (#3010)
  fix: check for overflow with hexadecimal inputs (#3004)
  feat(traits): Add trait impl for buildin types (#2964)
  feat(traits): added checks for duplicated trait associated items (types, consts, functions) (#2927)
  chore(formatter): trim spaces after opening brace (#3005)
  feat: format infix expressions (#3001)
  feat: provide formatting subcommand  (#2640)
  chore: Noir.js interface accepts a stuct of public inputs and proof (#2992)
  fix: Transform hir before type checks  (#2994)
  fix!: Make for loops a statement (#2975)
  feat: Add aztec selectors for event structs (#2983)
  fix(traits)!: trait functions with a default implementation must not be followed by a semicolon (#2987)
  chore: strip initialization of unused memory blocks from ACIR (#2985)
  chore: clippy fix (#2986)
  chore(ci): replace webdriver with playwright (#2988)
  ...
Sakapoi pushed a commit to Sakapoi/noir_fork that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants