chore: standardize witness map serialization format in JS #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
TomAFrench
added a commit
that referenced
this pull request
Oct 12, 2023
* master: chore: clean up JS dependencies (#3114) chore: add call formatter (#3102) chore: remove unnecessary clone when executing brillig (#3120) feat: return compilation errors from noir_wasm (#3091) feat: Save Brillig execution state in ACVM (#3026) chore: add method call formatter (#3106) feat!: Pass ACIR to ACVM by reference rather than passing ownership (#2872) chore: add member access formatter (#3109) fix: Determinism of fallback transformer (#3100) chore: clippy (#3108) feat: adding destroy and options object (#3105) chore: standardize witness map serialization format in JS (#3104) chore: add support for index expressions in formatter (#3069) feat: Implement impl specialization (#3087) chore: Update ACIR artifacts (#3086)
TomAFrench
added a commit
that referenced
this pull request
Oct 12, 2023
TomAFrench
added a commit
that referenced
this pull request
Oct 12, 2023
* master: (29 commits) fix: minor problems with `aztec` publishing (#3095) chore: clean up JS dependencies (#3114) chore: add call formatter (#3102) chore: remove unnecessary clone when executing brillig (#3120) feat: return compilation errors from noir_wasm (#3091) feat: Save Brillig execution state in ACVM (#3026) chore: add method call formatter (#3106) feat!: Pass ACIR to ACVM by reference rather than passing ownership (#2872) chore: add member access formatter (#3109) fix: Determinism of fallback transformer (#3100) chore: clippy (#3108) feat: adding destroy and options object (#3105) chore: standardize witness map serialization format in JS (#3104) chore: add support for index expressions in formatter (#3069) feat: Implement impl specialization (#3087) chore: Update ACIR artifacts (#3086) feat: Implement automatic dereferencing for indexing lvalues (#3083) fix: disallow returning constant values (#2978) feat: Implement automatic dereferencing for index expressions (#3082) feat: add `execute` method to `Noir` class (#3081) ...
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #2771
Summary*
This PR standardizes how we pass witness maps around between packages.
Previously we had 3 formats:
WitnessMapUint8ArrayThis PR removes usage of the uncompressed
Uint8Arrayformat, the witness is now decompressed immediately before being passed tobb.jsrather than inside theNoirclass.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.