chore: use circuit.get_assert_message instead of closure/helper function
#3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
approved these changes
Oct 12, 2023
ghost
mentioned this pull request
2 tasks
TomAFrench
added a commit
that referenced
this pull request
Oct 12, 2023
* master: feat: Optimize euclidean division acir-gen (#3121) chore: simplify `AcirVarData` where possible in multiplication (#3124) feat: Remove unnecessary truncation of boolean multiplication (#3122) chore: use `circuit.get_assert_message` instead of closure/helper function (#3127) fix: minor problems with `aztec` publishing (#3095) chore: clean up JS dependencies (#3114) chore: add call formatter (#3102) chore: remove unnecessary clone when executing brillig (#3120) feat: return compilation errors from noir_wasm (#3091)
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
…ction (noir-lang#3127) Co-authored-by: Tom French <git@tomfren.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
We currently don't use
circuit.get_assert_messageas previously it caused issues related to ownership over the circuit's opcodes. Now we pass the opcodes to the ACVM by reference, we can just use thecircuit.get_assert_messagedirectly.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.