Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(acir): Handle dynamic array operations for nested slices #3187

Merged
merged 66 commits into from
Nov 3, 2023
Merged

feat(acir): Handle dynamic array operations for nested slices #3187

merged 66 commits into from
Nov 3, 2023

Commits on Sep 14, 2023

  1. enabled dynamic indices on nested arrays

    @vezenovm
    vezenovm committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    c2f2f62 View commit details
    Browse the repository at this point in the history

  2. remove debug

    @vezenovm
    vezenovm committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    45b3787 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. working non-homogenous arr accesses for block params

    @vezenovm
    vezenovm committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    7ccf8e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. add array_set, broken, need to maintain structure from SSA for accura… 

    …te index
    @vezenovm
    vezenovm committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    d5d16d7 View commit details
    Browse the repository at this point in the history

  2. merge conflcits w/ master

    @vezenovm
    vezenovm committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ec54e01 View commit details
    Browse the repository at this point in the history

  3. working non-homogenous arrays using internal type element size array,… 

    … heavy cleanup still needed
    @vezenovm
    vezenovm committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e2eff9b View commit details
    Browse the repository at this point in the history

  4. cleanup lots of debug and move const index access into its own method

    @vezenovm
    vezenovm committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    219c8f2 View commit details
    Browse the repository at this point in the history

  5. updating array_get and array_set to reduce repeated code

    @vezenovm
    vezenovm committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    3195325 View commit details
    Browse the repository at this point in the history

  6. restrict dynamic indices for non-homogenous slices

    @vezenovm
    vezenovm committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8fb3bb1 View commit details
    Browse the repository at this point in the history

  7. cleanup array_get_value

    @vezenovm
    vezenovm committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    469c333 View commit details
    Browse the repository at this point in the history

  8. add internal_memory_blocks map

    @vezenovm
    vezenovm committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    0648142 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. do not make separate bool for handle_constant_index

    @vezenovm
    vezenovm committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    b99f0e2 View commit details
    Browse the repository at this point in the history

  2. fetch dummy value with predicate index

    @vezenovm
    vezenovm committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    5784170 View commit details
    Browse the repository at this point in the history

  3. flatten the index once for both array_set and array_get, do not modif… 

    …y modify the predicate index for the non-dummy val
    @vezenovm
    vezenovm committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    05f35c6 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. remove first_elem param

    @vezenovm
    vezenovm committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    f2dd702 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. initial slice changes with fetch flat size from SSA values, need to g… 

    …et element type size array correct
    @vezenovm
    vezenovm committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    490f5af View commit details
    Browse the repository at this point in the history

  2. merge master

    @vezenovm
    vezenovm committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    0037867 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. initial working nested dynamic slices

    @vezenovm
    vezenovm committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    3636bc6 View commit details
    Browse the repository at this point in the history

  2. cleanup and fmt

    @vezenovm
    vezenovm committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    31e7bc2 View commit details
    Browse the repository at this point in the history

  3. cargo clippy and fmt

    @vezenovm
    vezenovm committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    4354b76 View commit details
    Browse the repository at this point in the history

  4. merge conflicts w/ master

    @vezenovm
    vezenovm committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    87e8314 View commit details
    Browse the repository at this point in the history

  5. remove boolean AcirType

    @vezenovm
    vezenovm committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    658d234 View commit details
    Browse the repository at this point in the history

  6. remove deaad code not in master

    @vezenovm
    vezenovm committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    408ac2c View commit details
    Browse the repository at this point in the history

  7. better solution for fetching nested slice with multiple slice mergesr

    @vezenovm
    vezenovm committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    22ce20c View commit details
    Browse the repository at this point in the history

  8. bring back assert in nested_array_dynamic

    @vezenovm
    vezenovm committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    686640e View commit details
    Browse the repository at this point in the history

  9. add assert to nested_slice_dynamic test

    @vezenovm
    vezenovm committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    626616b View commit details
    Browse the repository at this point in the history

  10. cleanup w/ copy_dynamic_array method

    @vezenovm
    vezenovm committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    f60183c View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. starting test for slices in struct fields

    @vezenovm
    vezenovm committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    be5dc79 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. more initial debugging for adding slices to struct fields

    @vezenovm
    vezenovm committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    a7fde3e View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. basic slice struct fields working, but broken for struct fields of di… 

    …fferent lengths
    @vezenovm
    vezenovm committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    d1c9192 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. got old nested array and slice working with new acir, basic array get… 

    … and set working for slice fields, fix flattening
    @vezenovm
    vezenovm committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    6ab1212 View commit details
    Browse the repository at this point in the history

  2. merged w/ master, and working old nested arr/slice tests, array_set f… 

    …rom flattening still broken
    @vezenovm
    vezenovm committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    d5911b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. heavy debugging work to get flattening with slice of slices working

    @vezenovm
    vezenovm committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b9c6a0a View commit details
    Browse the repository at this point in the history

  2. working slice field in a struct

    @vezenovm
    vezenovm committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    11f7dc8 View commit details
    Browse the repository at this point in the history

  3. little test func for flattened slice size of res

    @vezenovm
    vezenovm committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7f4c822 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. merge conflicts w/ master

    @vezenovm
    vezenovm committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    d97b965 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Merge branch 'master' into mv/slice-struct-fields

    @vezenovm
    vezenovm committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    20f61a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. merge conflicts w/ master

    @vezenovm
    vezenovm committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    37a0f0f View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. update slice struct fields to use map of slice sizes in ACIR gen

    @vezenovm
    vezenovm committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    1e0bd3f View commit details
    Browse the repository at this point in the history

  2. clean up dbgs and old debug in acvm

    @vezenovm
    vezenovm committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    3b08844 View commit details
    Browse the repository at this point in the history

  3. cleanup

    @vezenovm
    vezenovm committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    9086383 View commit details
    Browse the repository at this point in the history

  4. comments update

    @vezenovm
    vezenovm committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    f1c707c View commit details
    Browse the repository at this point in the history

  5. check if we have side effects enabeld when flattening index

    @vezenovm
    vezenovm committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    9108769 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into mv/slice-struct-fields

    @vezenovm
    vezenovm committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    589185c View commit details
    Browse the repository at this point in the history

  7. cleanup

    @vezenovm
    vezenovm committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    4209388 View commit details
    Browse the repository at this point in the history

  8. add TODOs to value merger

    @vezenovm
    vezenovm committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    2949302 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Merge branch 'master' into mv/slice-struct-fields

    @vezenovm
    vezenovm committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    1456af9 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Merge branch 'master' into mv/slice-struct-fields 

    * master: (86 commits)
  chore: Add a workflow to build with feature flag (#3378)
  chore: fix for-loop in aztec-library (#3377)
  feat!: return Pedersen structure in stdlib (#3190)
  feat: Manage breakpoints and allow restarting a debugging session (#3325)
  chore: small driver refactors (#3375)
  fix: fixing versioning workflow (#3296)
  feat!: noir-wasm outputs debug symbols (#3317)
  chore: build acvm_js for integration tests in parallel (#3368)
  chore: replace bash with `@actions/github-script` (#3369)
  feat(noir_js): allow providing foreign call handlers in noirJS (#3294)
  feat: Allow traits to have generic functions (#3365)
  chore(ci): ensure that acir artifacts are published on master (#3367)
  chore: cleanup CI workflows to be more consistent (#3366)
  fix: Use pedersen_hash for merkle tree (#3357)
  chore: format `for` stmt (#3333)
  fix!: move mimc to hash submodule (#3361)
  fix: remove sha2_block test (#3360)
  chore: deduplicate dependencies across the workspace (#3356)
  chore: Add links to complete NoirJS app code to the guide (#3359)
  chore: clippy fixes (#3358)
  ...
    @TomAFrench
    TomAFrench committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    e58dbba View commit details
    Browse the repository at this point in the history

  2. Update compiler/noirc_evaluator/src/ssa/acir_gen/mod.rs 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    @vezenovm @TomAFrench
    vezenovm and TomAFrench authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    f30062e View commit details
    Browse the repository at this point in the history

  3. feat(slices): Fill slice internal dummy data initial pass (#3258) 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <tom@tomfren.ch>
Co-authored-by: jfecher <jake@aztecprotocol.com>
    @vezenovm @TomAFrench @jfecher
    4 people authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    dd3baec View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. simplify predicate logic when fetching flattened index

    @vezenovm
    vezenovm committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    3b30290 View commit details
    Browse the repository at this point in the history

  2. Update compiler/noirc_evaluator/src/ssa/acir_gen/mod.rs 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    @vezenovm @TomAFrench
    vezenovm and TomAFrench authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    4926713 View commit details
    Browse the repository at this point in the history

  3. use ok_or_else on store value slice sizes

    @vezenovm
    vezenovm committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    24bfae9 View commit details
    Browse the repository at this point in the history

  4. reduce nesting from compute_slice_sizes in acir gen

    @vezenovm
    vezenovm committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    a8dae7a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into mv/slice-struct-fields

    @vezenovm
    vezenovm authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    d558647 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into mv/slice-struct-fields

    @jfecher
    jfecher authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    ed372cc View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Merge branch 'master' into mv/slice-struct-fields

    @vezenovm
    vezenovm authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ff280cb View commit details
    Browse the repository at this point in the history

  2. revert merge of 3258

    @vezenovm
    vezenovm committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    402f421 View commit details
    Browse the repository at this point in the history

  3. use slice not mutable vec for array_get_value

    @vezenovm
    vezenovm committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5286fd1 View commit details
    Browse the repository at this point in the history

  4. comment out failing constraints fixed by fill internal slices pass

    @vezenovm
    vezenovm committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    96805de View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Update compiler/noirc_evaluator/src/ssa/acir_gen/mod.rs 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    @vezenovm @TomAFrench
    vezenovm and TomAFrench authored Nov 3, 2023
    Configuration menu
    Copy the full SHA
    c7649d3 View commit details
    Browse the repository at this point in the history

  2. wrap parent_array in Some

    @vezenovm
    vezenovm committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    bf0aa94 View commit details
    Browse the repository at this point in the history

  3. Update compiler/noirc_evaluator/src/ssa/acir_gen/mod.rs 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    @vezenovm @TomAFrench
    vezenovm and TomAFrench authored Nov 3, 2023
    Configuration menu
    Copy the full SHA
    2528f3d View commit details
    Browse the repository at this point in the history

  4. add comments for slize sizes

    @vezenovm
    vezenovm committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    38669e9 View commit details
    Browse the repository at this point in the history

  5. remove catch all for contains_slice_element

    @vezenovm
    vezenovm committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    2b446a1 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into mv/slice-struct-fields

    @vezenovm
    vezenovm authored Nov 3, 2023
    Configuration menu
    Copy the full SHA
    33beadf View commit details
    Browse the repository at this point in the history