chore(ci): Generate circuit benchmark summaries on PRs #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
|
Here's an example output Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
|
wow :D |
|
Exciting! cc @jfecher dream coming true! |
|
This may need an admin merge. Looks like the action is going to search through the entire history for a baseline benchmark artifact. |
|
We can improve the action to simplify the bootstrapping experience but this should allow us to get started using it. |
kevaundray
reviewed
Oct 23, 2023
|
|
||
| - name: Compare gates reports | ||
| id: gates_diff | ||
| uses: TomAFrench/noir-gates-diff@e7cf131b7e7f044c01615f93f0b855f65ddc02d4 |
There was a problem hiding this comment.
we can change this in a followup PR
There was a problem hiding this comment.
Yeah, we need to do some iterations before we can make a proper releases of the action.
guipublic
pushed a commit
that referenced
this pull request
Oct 23, 2023
guipublic
pushed a commit
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #3182
Summary*
This PR adds benchmarking for how PRs affect the number of opcodes/constraints generated for the programs in the
execution_successtest suite. If a PR changes the ACIR generated then a sticky comment will be added to the PR with a summary of the changes.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.