Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create publish-docs.yml #3298

Merged
merged 4 commits into from
Oct 26, 2023
Merged

chore: create publish-docs.yml #3298

merged 4 commits into from
Oct 26, 2023

Conversation

signorecello
Copy link
Contributor

Description

Problem*

I can't trigger a new workflow if it's not already on master, so I don't even know if this will work. But I can then iterate on it from my test branch

Summary*

Adds an attempt to set a publish workflow that runs when release-please triggers it

I can't trigger a new workflow if it's not already on master, so I don't even know if this will work. But I can then iterate on it from my test branch
@signorecello
Copy link
Contributor Author

There's also no dispatch from release-please, so it wouldn't trigger anyway

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this as is as we're just generating previews.

To properly automate the docs release workflow we'd have to move a portion of this into the release.yml workflow so that we can persist the changes to the md files.

@TomAFrench TomAFrench added this pull request to the merge queue Oct 26, 2023
Merged via the queue into master with commit b45f3a1 Oct 26, 2023
26 checks passed
@TomAFrench TomAFrench deleted the signorecello-patch-2 branch October 26, 2023 13:33
guipublic pushed a commit that referenced this pull request Oct 26, 2023
Co-authored-by: Tom French <tom@tomfren.ch>
guipublic pushed a commit that referenced this pull request Oct 27, 2023
Co-authored-by: Tom French <tom@tomfren.ch>
guipublic pushed a commit that referenced this pull request Oct 30, 2023
Co-authored-by: Tom French <tom@tomfren.ch>
TomAFrench added a commit that referenced this pull request Oct 30, 2023
* master: (242 commits)
  chore(docs): Update Windows installation  (#3326)
  chore!: change stdlib function `pedersen` to `pedersen_commitment` (#3341)
  chore: add back algolia recrawler (#3332)
  chore: comment out algolia recrawler workflow as its failing master (#3331)
  chore: Modify single line if-else expression width threshold (#3329)
  feat: Expand trait impl overlap check to cover generic types (#3320)
  feat: Implement where clauses on impls (#3324)
  chore: builtin wrapping shift left (#3270)
  chore: format integration tests  (#3257)
  fix(3300): cache warnings into debug artefacts (#3313)
  fix(3275): activate brillig modulo test with negative integers (#3318)
  feat: Add check for overlapping generic traits (#3307)
  feat: Refactor debugger and separate core from UI (#3308)
  chore: recrawl docs on merge (#3306)
  chore: add bn254 attribute when needed in the stdlib (#3208)
  feat: add exports of JS black box solvers to noirJS (#3295)
  chore: upload acir artifacts as a github artifact (#3288)
  chore: bump bb version to 0.12.0 (#3304)
  chore(docs): Supplement descriptions for defaulting loop indices to be `u64` (#3237)
  chore: create publish-docs.yml (#3298)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants