chore: clippy fixes

acvm-repo/barretenberg_blackbox_solver/src/wasm/pedersen.rs

@@ -23,7 +23,7 @@
         let result_ptr: usize = 0;
 
         self.call_multiple(
             "pedersen_plookup_commit_with_hash_index",
             vec![&input_ptr, &result_ptr.into(), &hash_index.into()],
         )?;
 
@@ -42,7 +42,7 @@
         let result_ptr: usize = 0;
 
         self.call_multiple(
             "pedersen_plookup_compress_with_hash_index",
             vec![&input_ptr, &result_ptr.into(), &hash_index.into()],
         )?;
 
@@ -57,8 +57,7 @@
 #[test]
 fn pedersen_hash_to_point() -> Result<(), Error> {
     let barretenberg = Barretenberg::new();
-    let (x, y) = barretenberg
-        .encrypt(vec![FieldElement::from(1 as u128), FieldElement::from(1 as u128)], 1)?;
+    let (x, y) = barretenberg.encrypt(vec![FieldElement::one(), FieldElement::one()], 1)?;
     let expected_x = FieldElement::from_hex(
         "0x12afb43195f5c621d1d2cabb5f629707095c5307fd4185a663d4e80bb083e878",
     )

compiler/noirc_frontend/src/hir/type_check/expr.rs

@@ -293,9 +293,9 @@ impl<'interner> TypeChecker<'interner> {
         argument_types: &mut [(Type, ExprId, noirc_errors::Span)],
     ) {
         let expected_object_type = match function_type {
-            Type::Function(args, _, _) => args.get(0),
+            Type::Function(args, _, _) => args.first(),
             Type::Forall(_, typ) => match typ.as_ref() {
-                Type::Function(args, _, _) => args.get(0),
+                Type::Function(args, _, _) => args.first(),
                 typ => unreachable!("Unexpected type for function: {typ}"),
             },
             typ => unreachable!("Unexpected type for function: {typ}"),

tooling/debugger/src/context.rs

@@ -111,7 +111,7 @@ impl<'a, B: BlackBoxFunctionSolver> DebugContext<'a, B> {
     }
 
     pub(super) fn step_into_opcode(&mut self) -> DebugCommandResult {
-        if matches!(self.brillig_solver, Some(_)) {
+        if self.brillig_solver.is_some() {
             self.step_brillig_opcode()
         } else {
             match self.acvm.step_into_brillig_opcode() {

tooling/nargo/src/errors.rs

@@ -91,7 +91,7 @@ fn extract_locations_from_error(
         _ => None,
     }?;
 
-    if let Some(OpcodeLocation::Brillig { acir_index, .. }) = opcode_locations.get(0) {
+    if let Some(OpcodeLocation::Brillig { acir_index, .. }) = opcode_locations.first() {
         opcode_locations.insert(0, OpcodeLocation::Acir(*acir_index));
     }
 

tooling/nargo_fmt/src/utils.rs

@@ -89,7 +89,7 @@
         let starts_with_single_line_comment = leading_trimmed.starts_with("//");
 
         if ends_with_block_comment {
             let comment_end = leading_trimmed.rfind(|c| c == '/').unwrap();
 
             if leading[comment_end..].contains('\n') {
                 different_line = true;
@@ -124,7 +124,6 @@
         Lexer::new(self)
             .skip_comments(false)
             .flatten()
-            .into_iter()
             .find_map(|spanned| f(spanned.token()).then(|| spanned.to_span().end()))
     }
 }