Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: format integration tests #3399

Merged
merged 3 commits into from Nov 16, 2023
Merged

chore: format integration tests #3399

merged 3 commits into from Nov 16, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 2, 2023

Description

find . -type f -name Nargo.toml -exec sh -c 'cd "$(dirname "{}")" && nargo fmt &> /dev/null || echo "Failed in: $(dirname "{}")"' \;
Failed in: ./tooling/nargo_cli/tests/test_libraries/bad_name
Failed in: ./tooling/nargo_cli/tests/compile_failure/depend_on_bin
Failed in: ./tooling/nargo_cli/tests/compile_failure/package_name_empty
Failed in: ./tooling/nargo_cli/tests/compile_failure/custom_entry_not_found
Failed in: ./tooling/nargo_cli/tests/compile_failure/workspace_missing_toml
Failed in: ./tooling/nargo_cli/tests/compile_failure/workspace_missing_toml/crates/b
Failed in: ./tooling/nargo_cli/tests/compile_failure/invalid_dependency_name
Failed in: ./tooling/nargo_cli/tests/compile_failure/package_name_hyphen

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

noir_stdlib/src/sha512.nr Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Nov 16, 2023

@jfecher

Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this now. There are some remaining parts that may be a bit questionable but overall I think there is a lot more that are good. For the remaining bits we can open issues for them and tackle them at a later date.

@jfecher jfecher added this pull request to the merge queue Nov 16, 2023
Merged via the queue into noir-lang:master with commit fac19a3 Nov 16, 2023
33 checks passed
@TomAFrench
Copy link
Member

I'm really not a fan of how the formatter is collapsing code sections separated with a blank line together if there's a comment between them. This severely hampers readability for me.

@ghost
Copy link
Author

ghost commented Nov 17, 2023

@TomAFrench, ok, I'll fix it

TomAFrench added a commit that referenced this pull request Nov 17, 2023
* master:
  chore: update `async-lsp` to v0.1.0 (#3489)
  fix: adding proving key initialization (#3322)
  chore(fmt): don't lose line breaks between comments (#3505)
  feat: Add LSP command to profile opcodes in vscode (#3496)
  chore: format integration tests (#3399)
  chore: Refactor parser tests (with concat!()) (#3500)
  chore: format function signature (#3495)
  chore: update `self_cell` to v1.0.2 (#3487)
  chore: Fix broken link (#3497)
  chore: update array formatting style (#3486)
  chore(fmt): add fn_call_width (#3480)
  chore: Fix undesirable line break before '{' in function signature with comments (#3473)
  fix: apply predicate to over/underflow checks (#3494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants