chore: Remove panic on arm64 linux builds for bb binary at compile time #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, we just don't want it for arm64 because BB doesn't produce those -- Additionally, we can follow up with another PR that allows users to specifically set that they want no backend like what was done here CC @guipublic to take that on as a followup work to your "compile no-backend" PR |
charlielye
approved these changes
Nov 22, 2023
TomAFrench
added a commit
that referenced
this pull request
Nov 27, 2023
* master: (39 commits) chore: Rename error2 variable (#3584) chore: nargo fmt (#3587) feat: codegen typed interfaces for functions in `noir_codegen` (#3533) chore: add dependency on noir_js from docs package (#3559) chore: Docs 0.19.3 (#3545) chore(debugger): Inject abstract foreign call executor to debugger (#3550) chore: nargo fmt (#3549) fix: Compiler version error message (#3558) chore(docs): Update link to docs' GitHub (#3555) chore(fmt): refactor the way we handle shapes in the formatter (#3546) feat: add --check option to nargo fmt for dry-run formatting verification (#3530) chore: Update ACIR artifacts (#3528) chore: Release Noir(0.19.3) (#3514) chore: Updates bb dependency to 0.15.1 (#3536) fix(debugger): Step through foreign calls and breakpoints inside Brillig blocks (#3511) chore: Add build profiles that optimize for size (#3534) chore: clippy fixes (#3529) chore: remove early return from build.rs (#3531) feat: enable the `fmt` command in the help menu (#3328) chore: Remove panic on arm64 linux builds for bb binary at compile time (#3527) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the addition of #3437 -- we can compile without a backend. If one is on an arm64 linux build, they will get a compile time panic. This PR changes it to a warning and just doesn't set the environment variables for the bb binary.
Problem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.