Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): always build docs #4062

Merged
merged 6 commits into from
Jan 19, 2024
Merged

chore(ci): always build docs #4062

merged 6 commits into from
Jan 19, 2024

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR splits building and deploying a preview of the docs. This should enforce that docs are always ready to be published without generating a large number of unnecessary deploys.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member Author

@kevaundray Could you add this new build step as a required check? We should ensure that the docs always build.

@kevaundray kevaundray added this pull request to the merge queue Jan 19, 2024
@kevaundray
Copy link
Contributor

@TomAFrench You should be able to add these required checks now

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 19, 2024
@TomAFrench TomAFrench added this pull request to the merge queue Jan 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 19, 2024
@TomAFrench TomAFrench added this pull request to the merge queue Jan 19, 2024
Merged via the queue into master with commit 74406ac Jan 19, 2024
31 checks passed
@TomAFrench TomAFrench deleted the tf/always-build-docs branch January 19, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants