Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove panic for unsupported types in aztec contract interface #4074

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

Having an unsupported type in the interface of an Aztec contract currently causes the compile to panic. This PR replaces this with a proper error.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TomAFrench TomAFrench added this pull request to the merge queue Jan 18, 2024
Merged via the queue into master with commit 5999d0e Jan 18, 2024
30 checks passed
@TomAFrench TomAFrench deleted the tf/remove-panic-from-macro branch January 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants