Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace explicit subtractions with nots #4097

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

Small PR to replace usage of (1-x) instead of not(x) for boolean x. This improves readability of the codegen imo.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member Author

sha2_byte	+28,332 ❌	+71.38%	+118,018 ❌	+76.92%
  1. what

@TomAFrench
Copy link
Member Author

TomAFrench commented Jan 19, 2024

Ok making this draft as I want to investigate but this isn't high prio atm.

Edit: noticed on the diff that we're using the wrong type in pow which is likely behind this.

@TomAFrench TomAFrench marked this pull request as draft January 19, 2024 11:18
@TomAFrench TomAFrench marked this pull request as ready for review January 19, 2024 18:39
Copy link
Contributor

@vezenovm vezenovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but tagging @guipublic as I believe he wrote this pow function.

@TomAFrench TomAFrench added this pull request to the merge queue Jan 22, 2024
Merged via the queue into master with commit 199d129 Jan 22, 2024
31 checks passed
@TomAFrench TomAFrench deleted the tf/not-over-sub branch January 22, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants