-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sync from aztec-packages #4581
Merged
Merged
Commits on Mar 19, 2024
-
feat!: automatic NoteInterface and NoteGetterOptions auto select (Azt…
…ecProtocol/aztec-packages#4508) Partially addresses: AztecProtocol/aztec-packages#4519 (moved autogeneration to the macro, even if not incremental) Closes: AztecProtocol/aztec-packages#3011 Added the `#[aztec(note)]` attribute, which automatically implements most of the `NoteInterface` trait in a struct marked as such, plus several utilities. Even if this adds a fair share of "magic" to the note implementation logic, it is structured in a way that it's hopefully easy to follow, including meaningful errors attached to the correct span during the process. ![Screenshot 2024-03-14 at 14 59 07](https://github.com/AztecProtocol/aztec-packages/assets/5404052/84a3d6e4-e346-4cfe-93eb-ec317632f344) Hey you! Implement the trait! ![Screenshot 2024-03-14 at 14 46 39](https://github.com/AztecProtocol/aztec-packages/assets/5404052/bebfb3dd-c178-44d0-b9bc-005b5c9f0f38) But only the meat and potatoes though. As long as the user doesn't want to do any custom stuff, `get_header`, `set_header`, `compute_note_content_hash`, `get_note_type_id`, `serialize_content` and `deserialize_content` get automatically implemented. Any combination of them can be overridden by the developer though. A metadata struct is also added, which takes the following form: ```rust struct CardNote { points: FieldSelector, randomness: FieldSelector, owner: FieldSelector, } ``` This is used to implement a `properties()` function, which in turn can be used in conjunction with the `NoteGetterOptions.select` and `.sort` <img width="697" alt="Screenshot 2024-03-18 at 15 27 27" src="https://github.com/AztecProtocol/aztec-packages/assets/5404052/5da531b3-0b7f-4cf9-9908-300ff8d98c6d">
Configuration menu - View commit details
-
Copy full SHA for 6b4175e - Browse repository at this point
Copy the full SHA 6b4175eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0986c09 - Browse repository at this point
Copy the full SHA 0986c09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bb168a - Browse repository at this point
Copy the full SHA 9bb168aView commit details
Commits on Mar 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7d94107 - Browse repository at this point
Copy the full SHA 7d94107View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1615085 - Browse repository at this point
Copy the full SHA 1615085View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9a637a - Browse repository at this point
Copy the full SHA c9a637aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06b10d2 - Browse repository at this point
Copy the full SHA 06b10d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45e0613 - Browse repository at this point
Copy the full SHA 45e0613View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec976b3 - Browse repository at this point
Copy the full SHA ec976b3View commit details -
feat: Add CMOV instruction to brillig and brillig gen (AztecProtocol/…
…aztec-packages#5308) Resolves #4580
Configuration menu - View commit details
-
Copy full SHA for 7ddfd89 - Browse repository at this point
Copy the full SHA 7ddfd89View commit details -
feat: Add CMOV instruction to brillig and brillig gen (AztecProtocol/…
…aztec-packages#5308) Resolves #4580
Configuration menu - View commit details
-
Copy full SHA for 74ba792 - Browse repository at this point
Copy the full SHA 74ba792View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c7a236 - Browse repository at this point
Copy the full SHA 9c7a236View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79323ad - Browse repository at this point
Copy the full SHA 79323adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01f65ed - Browse repository at this point
Copy the full SHA 01f65edView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9b7116 - Browse repository at this point
Copy the full SHA c9b7116View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff36f9f - Browse repository at this point
Copy the full SHA ff36f9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2711d8 - Browse repository at this point
Copy the full SHA f2711d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22fe49c - Browse repository at this point
Copy the full SHA 22fe49cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a883c8 - Browse repository at this point
Copy the full SHA 2a883c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3cae5d - Browse repository at this point
Copy the full SHA c3cae5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3822e0 - Browse repository at this point
Copy the full SHA c3822e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 222b8ee - Browse repository at this point
Copy the full SHA 222b8eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dda846 - Browse repository at this point
Copy the full SHA 5dda846View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ba2675 - Browse repository at this point
Copy the full SHA 4ba2675View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63826ef - Browse repository at this point
Copy the full SHA 63826efView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9c7aec - Browse repository at this point
Copy the full SHA d9c7aecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40e8e77 - Browse repository at this point
Copy the full SHA 40e8e77View commit details -
Configuration menu - View commit details
-
Copy full SHA for c588a9a - Browse repository at this point
Copy the full SHA c588a9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdfddab - Browse repository at this point
Copy the full SHA bdfddabView commit details -
Configuration menu - View commit details
-
Copy full SHA for dde1831 - Browse repository at this point
Copy the full SHA dde1831View commit details
Commits on Mar 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a8e428c - Browse repository at this point
Copy the full SHA a8e428cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.