Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: regression test for #2540 #4602

Merged
merged 3 commits into from
Mar 20, 2024
Merged

chore: regression test for #2540 #4602

merged 3 commits into from
Mar 20, 2024

Conversation

michaeljklein
Copy link
Contributor

Description

Problem*

Resolves #2540

Summary*

Fixed in #4504

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@michaeljklein michaeljklein mentioned this pull request Mar 20, 2024
Closed
@TomAFrench
Copy link
Member

Could we move this into noirc_frontend like

noir/compiler/noirc_frontend/src/tests.rs

Lines 1259 to 1267 in 77f0381

// Regression for #4545
#[test]
fn type_aliases_in_main() {
let src = r#"
type Outer<N> = [u8; N];
fn main(_arg: Outer<1>) {}
"#;
assert_eq!(get_program_errors(src).len(), 0);
}
?

This should run faster for frontend errors rather than a full compilation.

@michaeljklein michaeljklein marked this pull request as draft March 20, 2024 18:02
jfecher
jfecher approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaeljklein michaeljklein marked this pull request as ready for review March 20, 2024 20:18
@michaeljklein michaeljklein added this pull request to the merge queue Mar 20, 2024
Merged via the queue into master with commit 3d1e456 Mar 20, 2024
41 checks passed
@michaeljklein michaeljklein deleted the michaeljklein/regression-test-2540 branch March 20, 2024 20:29
TomAFrench added a commit that referenced this pull request Mar 27, 2024
@TomAFrench
Merge branch 'master' into tf/unsafe-blocks
429aba6 
* master:
  chore: delete `R1CSTransformer` (#4649)
  fix: Slice coercions (#4640)
  chore(ci): add warning sticky comment (#4647)
  fix(ssa): Fix slice intrinsic handling in the capacity tracker  (#4643)
  chore: fix versioning of `bn254_blackbox_solver` crate (#4638)
  chore: fix acvm crates reporting errors as JS packages (#4637)
  chore: Release Noir(0.26.0) (#4526)
  chore: convert `BlockExpression` into a standard struct (#4623)
  chore(github): Improve PR template "document later" checkbox description (#4625)
  chore: Update integers.md to note support for Fields using `from_integer` (#4536)
  chore: update docs with function names to match version 0.25.0 specifications (#4466)
  feat: add specific error for attempting `string[x] = ".."` (#4611)
  fix(ssa): Use accurate type during SSA AsSlice simplficiation (#4610)
  feat: Sync from aztec-packages (#4581)
  chore: regression test for #2540 (#4602)
  chore: fix up benchmarking scripts (#4601)
  feat: Add experimental `quote` expression to parser (#4595)
  chore(ci): fix long debugger test times (#4599)
TomAFrench pushed a commit that referenced this pull request Apr 3, 2024
@michaeljklein @TomAFrench
chore: regression test for #2540 (#4602)
39c4e8a 
# Description

## Problem\*

Resolves #2540

## Summary\*

Fixed in #4504

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: non-numeric type variable Error
3 participants
@michaeljklein @TomAFrench @jfecher