chore(docs): fix wrong Nargo.toml workspace examples

[SihanoukSolver29]

Description

Problem*

Resolves #4805

Summary*

This PR fixes the issue found by @iAmMichaelConnor in #4805, where the example Nargo.toml content for [workspace] has
members with wrong paths.

Since the structure has Nargo.toml inside the crates folder, then members should direct to folders inside crates.

├── crates
│   ├── a
│   │   ├── Nargo.toml
│   │   └── src
│   │       └── main.nr
│   └── b
│       ├── Nargo.toml
│       └── src
│           └── main.nr
├── Nargo.toml
└── Prover.toml

Additional Context

All nargo versions I've tested with, from v0.19.0 to v0.27.0, return Cannot read file /home/sihanouk/crates/crates/a/Nargo.toml - does it exist? without the fix.

Documentation*

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

Thank you for your contribution to the Noir language.

Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.

Thanks for your understanding.

[TomAFrench]

Since the structure has Nargo.toml inside the crates folder, then members should direct to folders inside crates.

This isn't the case though.

├── crates
│   ├── a
│   │   ├── Nargo.toml
│   │   └── src
│   │       └── main.nr
│   └── b
│       ├── Nargo.toml
│       └── src
│           └── main.nr
├── Nargo.toml
└── Prover.toml

In this diagram Nargo.toml is on the same level as crates and so it doesn't sit inside of it. See this example https://github.com/noir-lang/noir/tree/master/test_programs/execution_success/workspace

Althought it does seem that the diagram as listed in the docs is incorrect, it should be:

├── crates
│   ├── a
│   │   ├── Nargo.toml
│   │   └── src
│   │       ├── main.nr
│   │       └── Prover.toml
│   └── b
│       ├── Nargo.toml
│       └── src
│           ├── main.nr
│           └── Prover.toml
│
└── Nargo.toml

[SihanoukSolver29]

@TomAFrench Hello,

Thanks for the response. Based on the example, I think the correct structure would look more like this:

├── crates
│   ├── a
│   │   ├── Nargo.toml
│   │   └── Prover.toml
│   │   └── src
│   │       └── main.nr
│   └── b
│       ├── Nargo.toml
│       └── Prover.toml
│       └── src
│           └── main.nr
│
└── Nargo.toml
└── Prover.toml

[TomAFrench]

That extra Prover.toml is unnecessary, see #4829

[TomAFrench]

Ah, yeah I chucked the Prover.tomls into the src folders by mistake. We should fix that.

├── crates
│   ├── a
│   │   ├── Nargo.toml
│   │   └── Prover.toml
│   │   └── src
│   │       └── main.nr
│   └── b
│       ├── Nargo.toml
│       └── Prover.toml
│       └── src
│           └── main.nr
│
└── Nargo.toml

This is correct.

[TomAFrench]

LGTM. Thanks for helping with this issue!

[iAmMichaelConnor]

Wait, this doesn't resolve the issue. The main thing I was taking issue with was the content of the top-level Nargo.toml:

It shouldn't contain the crates/ word in the paths.

[iAmMichaelConnor]

Seems like I don't have permissions to re-open the closed issue

[TomAFrench]

Have you placed your Nargo.toml file inside of the crates directory? If so then you should move it up and out of that directory.

[TomAFrench]

The workspace structure in the docs are reflected in the tests with here which doesn't throw any errors if I run nargo compile from the workspace root.