Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): Call trait method with mut self from generic definition #5041

Merged
merged 63 commits into from
May 21, 2024
Merged

fix(frontend): Call trait method with mut self from generic definition #5041

merged 63 commits into from
May 21, 2024

Commits on Nov 21, 2023

  1. Add turbofish operator; add stack overflow crash

    @jfecher
    jfecher committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    04ea5d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Fix parsing error

    @jfecher
    jfecher committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    3a95229 View commit details
    Browse the repository at this point in the history

  2. Add test

    @jfecher
    jfecher committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    427cb95 View commit details
    Browse the repository at this point in the history

  3. Add compiler error for incorrect generic count

    @jfecher
    jfecher committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    3ab58b8 View commit details
    Browse the repository at this point in the history

  4. Edit example to have a more problematic case

    @jfecher
    jfecher committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    8fc453a View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Merge branch 'master' into jf/turbofish 

    * master: (120 commits)
  feat: allow passing custom foreign call handlers when creating proofs in NoirJS (#3764)
  fix: add missing assertion to test (#3765)
  chore: re-export the items needed for the lsp from the fm crate instead of importing codespan_reporting (#3757)
  chore: remove special casing for `pedersen_hash` black box function (#3744)
  chore: remove extraneous dbg statement (#3761)
  chore: fix un-needed fully qualified path (#3755)
  feat: aztec-packages (#3754)
  feat: allow underscores in integer literals (#3746)
  fix: deserialize odd length hex literals (#3747)
  feat: optimize out unnecessary truncation instructions (#3717)
  chore: use `tsx` instead of `ts-node` for `noir_js` (#3750)
  chore(ci): fail `tests-end` job if any dependants failed (#3737)
  chore: allow common ascii punctuation in attributes (#3733)
  chore: fix broken onboarding link in README (#3732)
  feat: Dockerfile to test cargo and JS packages (#3684)
  feat(lsp): add goto definition for locals (#3705)
  feat: docs landing page with a playground (#3667)
  fix: `try_unify` no longer binds types on failure (#3697)
  fix: parse negative integer literals (#3698)
  fix: unsigned integers cannot be negated (#3688)
  ...
    @TomAFrench
    TomAFrench committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    4050fe5 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. resolved merge conflicts

    @vezenovm
    vezenovm committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b9673b2 View commit details
    Browse the repository at this point in the history

  2. fixup remaining fmt stuff

    @vezenovm
    vezenovm committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b289b87 View commit details
    Browse the repository at this point in the history

  3. cleanup

    @vezenovm
    vezenovm committed May 14, 2024
    Configuration menu
    Copy the full SHA
    6127baf View commit details
    Browse the repository at this point in the history

  4. cargo fmt

    @vezenovm
    vezenovm committed May 14, 2024
    Configuration menu
    Copy the full SHA
    9ebb3b5 View commit details
    Browse the repository at this point in the history

  5. working initial turbofish tests

    @vezenovm
    vezenovm committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c652541 View commit details
    Browse the repository at this point in the history

  6. cargo fmt

    @vezenovm
    vezenovm committed May 14, 2024
    Configuration menu
    Copy the full SHA
    9660360 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. nargo fmt

    @vezenovm
    vezenovm committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4cee817 View commit details
    Browse the repository at this point in the history

  2. clippy

    @vezenovm
    vezenovm committed May 15, 2024
    Configuration menu
    Copy the full SHA
    e89cde2 View commit details
    Browse the repository at this point in the history

  3. fmt

    @vezenovm
    vezenovm committed May 15, 2024
    Configuration menu
    Copy the full SHA
    a2da705 View commit details
    Browse the repository at this point in the history

  4. nargo fmt

    @vezenovm
    vezenovm committed May 15, 2024
    Configuration menu
    Copy the full SHA
    da23029 View commit details
    Browse the repository at this point in the history

  5. fix nargo fmt for turbofish on method calls

    @vezenovm
    vezenovm committed May 15, 2024
    Configuration menu
    Copy the full SHA
    da26bc3 View commit details
    Browse the repository at this point in the history

  6. clippy

    @vezenovm
    vezenovm committed May 15, 2024
    Configuration menu
    Copy the full SHA
    77dfc19 View commit details
    Browse the repository at this point in the history

  7. initial work to get calling trait methods working, decided this would… 

    … be better as a separate PR
    @vezenovm
    vezenovm committed May 15, 2024
    Configuration menu
    Copy the full SHA
    0e5a579 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. working turbofish with implicit generics now

    @vezenovm
    vezenovm committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c17e834 View commit details
    Browse the repository at this point in the history

  2. separate out function and implicit generic counts

    @vezenovm
    vezenovm committed May 16, 2024
    Configuration menu
    Copy the full SHA
    8f2be2e View commit details
    Browse the repository at this point in the history

  3. merge conflicts w/ jf/turbofish and working trait methods with mutabl… 

    …e self
    @vezenovm
    vezenovm committed May 16, 2024
    Configuration menu
    Copy the full SHA
    405683e View commit details
    Browse the repository at this point in the history

  4. cleanup

    @vezenovm
    vezenovm committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5ad8fb4 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into jf/turbofish

    @vezenovm
    vezenovm authored May 16, 2024
    Configuration menu
    Copy the full SHA
    e7000d7 View commit details
    Browse the repository at this point in the history

  6. merge conflicts w/ parent jf/turbofish

    @vezenovm
    vezenovm committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3cbba0b View commit details
    Browse the repository at this point in the history

  7. cargo fmt

    @vezenovm
    vezenovm committed May 16, 2024
    Configuration menu
    Copy the full SHA
    cc135e7 View commit details
    Browse the repository at this point in the history

  8. cleanup

    @vezenovm
    vezenovm committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a0090c1 View commit details
    Browse the repository at this point in the history

  9. nargo fmt

    @vezenovm
    vezenovm committed May 16, 2024
    Configuration menu
    Copy the full SHA
    954aba7 View commit details
    Browse the repository at this point in the history

  10. add todo comments

    @vezenovm
    vezenovm committed May 16, 2024
    Configuration menu
    Copy the full SHA
    1e22003 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. specify type annotation for hasher

    @vezenovm
    vezenovm committed May 17, 2024
    Configuration menu
    Copy the full SHA
    44a4aee View commit details
    Browse the repository at this point in the history

  2. rename

    @vezenovm
    vezenovm committed May 17, 2024
    Configuration menu
    Copy the full SHA
    8d5c072 View commit details
    Browse the repository at this point in the history

  3. brought back removed comment

    @vezenovm
    vezenovm committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c6f3057 View commit details
    Browse the repository at this point in the history

  4. chore: add test for specifying types on function with turbofish

    @TomAFrench
    TomAFrench committed May 17, 2024
    Configuration menu
    Copy the full SHA
    384e26a View commit details
    Browse the repository at this point in the history

  5. chore: add test for using turbofish with generic methods

    @TomAFrench
    TomAFrench committed May 17, 2024
    Configuration menu
    Copy the full SHA
    98c5d89 View commit details
    Browse the repository at this point in the history

  6. chore: add turbofish to cspell

    @TomAFrench
    TomAFrench committed May 17, 2024
    Configuration menu
    Copy the full SHA
    32d1714 View commit details
    Browse the repository at this point in the history

  7. nargo fmt tests

    @vezenovm
    vezenovm committed May 17, 2024
    Configuration menu
    Copy the full SHA
    9ab7351 View commit details
    Browse the repository at this point in the history

  8. fix noirc_frontend tests

    @vezenovm
    vezenovm committed May 17, 2024
    Configuration menu
    Copy the full SHA
    b73d263 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. chore: update formatter test outputs

    @TomAFrench
    TomAFrench committed May 20, 2024
    Configuration menu
    Copy the full SHA
    a886946 View commit details
    Browse the repository at this point in the history

  2. Revert "chore: update formatter test outputs" 

    This reverts commit a886946.
    @TomAFrench
    TomAFrench committed May 20, 2024
    Configuration menu
    Copy the full SHA
    4125804 View commit details
    Browse the repository at this point in the history

  3. Update compiler/noirc_frontend/src/hir_def/expr.rs 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored May 20, 2024
    Configuration menu
    Copy the full SHA
    bc7abf8 View commit details
    Browse the repository at this point in the history

  4. have atom_or_right_unary accept a type parser

    @vezenovm
    vezenovm committed May 20, 2024
    Configuration menu
    Copy the full SHA
    8b1bbc4 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/jf/turbofish' into jf/turbofish

    @vezenovm
    vezenovm committed May 20, 2024
    Configuration menu
    Copy the full SHA
    cd1f59e View commit details
    Browse the repository at this point in the history

  6. clippy and fmt

    @vezenovm
    vezenovm committed May 20, 2024
    Configuration menu
    Copy the full SHA
    bd075fa View commit details
    Browse the repository at this point in the history

  7. Update compiler/noirc_frontend/src/hir/type_check/expr.rs 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored May 20, 2024
    Configuration menu
    Copy the full SHA
    b2100ad View commit details
    Browse the repository at this point in the history

  8. Update test_programs/execution_success/trait_method_mut_self/src/main.nr 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored May 20, 2024
    Configuration menu
    Copy the full SHA
    0d7fb67 View commit details
    Browse the repository at this point in the history

  9. Update test_programs/execution_success/trait_method_mut_self/src/main.nr 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored May 20, 2024
    Configuration menu
    Copy the full SHA
    c045540 View commit details
    Browse the repository at this point in the history

  10. fetch implicit generic count from node interner

    @vezenovm
    vezenovm committed May 20, 2024
    Configuration menu
    Copy the full SHA
    c6aed8c View commit details
    Browse the repository at this point in the history

  11. remove unused method implicit generics map

    @vezenovm
    vezenovm committed May 20, 2024
    Configuration menu
    Copy the full SHA
    9bf4ac2 View commit details
    Browse the repository at this point in the history

  12. add new line to expected formatter tests

    @vezenovm
    vezenovm committed May 20, 2024
    Configuration menu
    Copy the full SHA
    22e3cda View commit details
    Browse the repository at this point in the history

  13. fixup after code review

    @vezenovm
    vezenovm committed May 20, 2024
    Configuration menu
    Copy the full SHA
    af2c858 View commit details
    Browse the repository at this point in the history

  14. fmy and clippy

    @vezenovm
    vezenovm committed May 20, 2024
    Configuration menu
    Copy the full SHA
    aa8e49e View commit details
    Browse the repository at this point in the history

  15. Merge branch 'jf/turbofish' into mv/trait-method-reference

    @vezenovm
    vezenovm committed May 20, 2024
    Configuration menu
    Copy the full SHA
    af3cc88 View commit details
    Browse the repository at this point in the history

  16. update comment

    @vezenovm
    vezenovm committed May 20, 2024
    Configuration menu
    Copy the full SHA
    e6850e9 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. move where implciit_generic_count is computed

    @vezenovm
    vezenovm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    bf07ee8 View commit details
    Browse the repository at this point in the history

  2. switch to single loop in instantiate_with

    @vezenovm
    vezenovm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    a9cb6c4 View commit details
    Browse the repository at this point in the history

  3. rename to turbofish_generics

    @vezenovm
    vezenovm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    daf151b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into jf/turbofish

    @vezenovm
    vezenovm authored May 21, 2024
    Configuration menu
    Copy the full SHA
    0d887de View commit details
    Browse the repository at this point in the history

  5. Merge branch 'jf/turbofish' into mv/trait-method-reference

    @vezenovm
    vezenovm authored May 21, 2024
    Configuration menu
    Copy the full SHA
    8d93a66 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into jf/turbofish

    @vezenovm
    vezenovm authored May 21, 2024
    Configuration menu
    Copy the full SHA
    a44782b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'jf/turbofish' into mv/trait-method-reference

    @vezenovm
    vezenovm authored May 21, 2024
    Configuration menu
    Copy the full SHA
    d174e13 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into mv/trait-method-reference

    @vezenovm
    vezenovm authored May 21, 2024
    Configuration menu
    Copy the full SHA
    c05e917 View commit details
    Browse the repository at this point in the history

  9. remove duplicated function count

    @vezenovm
    vezenovm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c0b9684 View commit details
    Browse the repository at this point in the history

  10. missing stdlib format

    @vezenovm
    vezenovm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8a0d483 View commit details
    Browse the repository at this point in the history