# Description

## Problem\*

Fixes the "Duplicate definitions of <global> found" error by removing
`resolve_local_globals`.

## Summary\*



## Additional Context

We don't need to re-add globals to scope anymore via
`resolve_local_globals` since we're not creating a new Elaborator for
each function like we do for NameResolvers. The flip side of this is
that I think we'll need to change how globals are stored eventually so
that they're not all always visible. I think how it is now may violate
imports but I'll leave that for a later fix to keep these PRs small.
(and wait until I have a test case that shows it).

Down to 61 errors after this PR. The errors are:
- "Duplicate definitions of \<generic> found" - looks to be only one
case where there is a generic directly on a trait method. `fn
hash<H>(self, state: &mut H) where H: Hasher;`
- "Expression type is ambiguous" - from the two turbofish cases that
haven't been merged in this branch yet
- "Expected type &mut _, found type H" - issues with auto-deref and
trait methods possibly
- "No matching impl found for ..." - trait solver issues

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

#5105)

# Description

## Problem\*

Resolves "No matching impl found for ..." trait solver issues in the
elaborator.

## Summary\*

These issues were just because we'd add a trait impl to the interner
after elaborating the impl. At that point, we'd already have elaborated
all other functions & methods so it wasn't of much use. I've moved it to
add the trait impl to the interner during `collect_trait_impl` instead.

## Additional Context

Down to 6 errors after this PR. The errors are:
- "Duplicate definitions of \<generic> found" - looks to be only one
case where there is a generic directly on a trait method. `fn
hash<H>(self, state: &mut H) where H: Hasher;` (1 error)
- "Expected type &mut _, found type H" - issues with auto-deref and
trait methods possibly (5 errors)

(merging master has fixed the 2 "expression is ambiguous" errors from
the turbofish operator changes)

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
Co-authored-by: Álvaro Rodríguez <sirasistant@gmail.com>
Co-authored-by: guipublic <47281315+guipublic@users.noreply.github.com>