chore: remove duplicated code from LSP #5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
approved these changes
May 28, 2024
jfecher
reviewed
May 28, 2024
Co-authored-by: jfecher <jake@aztecprotocol.com>
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 29, 2024
fix(experimental elaborator): Avoid calling `add_generics` twice on trait methods (noir-lang/noir#5108) fix(experimental elaborator): Fix duplicate `resolve_type` on self type and don't leak a trait impl's generics (noir-lang/noir#5102) feat: replace stdlib poseidon implementation with optimized version (noir-lang/noir#5122) fix(experimental elaborator): Only call `add_generics` once (noir-lang/noir#5091) fix(experimental elaborator): Fix panic in the elaborator (noir-lang/noir#5082) chore: move `is_native_field` up into `noirc_frontend` (noir-lang/noir#5119)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 29, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: remove duplicated code from LSP (noir-lang/noir#5116) fix(experimental elaborator): Avoid calling `add_generics` twice on trait methods (noir-lang/noir#5108) fix(experimental elaborator): Fix duplicate `resolve_type` on self type and don't leak a trait impl's generics (noir-lang/noir#5102) feat: replace stdlib poseidon implementation with optimized version (noir-lang/noir#5122) fix(experimental elaborator): Only call `add_generics` once (noir-lang/noir#5091) fix(experimental elaborator): Fix panic in the elaborator (noir-lang/noir#5082) chore: move `is_native_field` up into `noirc_frontend` (noir-lang/noir#5119) END_COMMIT_OVERRIDE Co-authored-by: Tom French <tom@tomfren.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
We've got some copy pasted code here so I've added a helper function for converting a "position" to a "location".
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.