Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade IndexOutOfBounds to a warning #5465

Closed
wants to merge 1 commit into from

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves #5464

Summary*

This test was failing due to the error being found at compile-time and so a compile-time error was returned rather than the expected runtime error. I've then downgraded this error into a warning so that circuit execution can be performed so that the expected error is thrown.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench closed this Jul 10, 2024
auto-merge was automatically disabled July 10, 2024 09:41

Pull request was closed

@TomAFrench TomAFrench deleted the tf/warn-on-index-errors branch July 10, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACIR gen errors with some kinds of known failing constraints, changing expected errors in tests
1 participant