Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: filter warnings from elaborator in Aztec Macros #5556

Merged
merged 1 commit into from
Jul 18, 2024
+3 −2
Merged

chore: filter warnings from elaborator in Aztec Macros #5556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions aztec_macros/src/utils/hir_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use acvm::acir::AcirField;
use iter_extended::vecmap;
use noirc_errors::Location;
use noirc_errors::{CustomDiagnostic, Location};
use noirc_frontend::ast;
use noirc_frontend::elaborator::Elaborator;
use noirc_frontend::hir::def_collector::dc_crate::{
Expand Down Expand Up @@ -195,7 +195,8 @@
let trait_id = None;
items.functions.push(UnresolvedFunctions { file_id, functions, trait_id, self_type: None });

let errors = Elaborator::elaborate(context, *crate_id, items, None);
let mut errors = Elaborator::elaborate(context, *crate_id, items, None);
errors.retain(|(error, _)| !CustomDiagnostic::from(error).is_warning());

if !errors.is_empty() {
return Err(MacroError {
Expand Down Expand Up @@ -333,7 +334,7 @@
}
}

pub fn get_global_numberic_const(

Check warning on line 337 in aztec_macros/src/utils/hir_utils.rs

View workflow job for this annotation

GitHub Actions / Code 

Unknown word (numberic)
context: &HirContext,
const_name: &str,
) -> Result<u128, MacroError> {
Expand Down
Loading