Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: crypto blackbox tests #5614

Merged
merged 31 commits into from
Aug 26, 2024
Merged

chore: crypto blackbox tests #5614

merged 31 commits into from
Aug 26, 2024
+725 −34

Conversation

michaeljklein
Copy link
Contributor

@michaeljklein michaeljklein commented Jul 26, 2024 •
edited
Loading

Description

Problem*

Resolves #5427

Summary*

Unit test our blackbox crypto instructions.

Preferable to merge after:

(Because of overlapping helper functions)

Additional Context

While most of our crypto function implementations are from external crates, poseidon2_permutation is implemented internally. I'm using the zkhash crate to test our implementation.

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

michaeljklein and others added 10 commits July 26, 2024 11:39
@michaeljklein
add poseidon2_permutation smoke test draft
1685a7b
@michaeljklein
using external poseidon2 permutation impl for test, make internal pos…
d2b25d0 
…eidon2 permutation parameters public
@michaeljklein
convert test to property test, factor out test helper, use d=5
032ff31
@michaeljklein
wip sha256 tests
79bcd58
@michaeljklein
Merge branch 'master' into michaeljklein/crypto-blackbox-tests, add h…
aa04113 
…ash function solver setup, refactor solvers into shared solver, wip injectivity tests
@michaeljklein
Merge branch 'master' into michaeljklein/crypto-blackbox-tests
dc42993
@michaeljklein
wip: possible keccak256 bug, add keccak operations, add injectivity h…
56ac2fa 
…elper fn and tests, add _zeros smoke tests
@michaeljklein
wip debugging keccak256 test failure
2fccc6d
@michaeljklein
linting
ebeb12c
@michaeljklein
implement sha256 compression tests, add min size to distinct input ge…
674fe1c 
…nerator
This was referenced Aug 6, 2024
Closed
Closed
@michaeljklein michaeljklein marked this pull request as ready for review August 6, 2024 19:54
@michaeljklein michaeljklein requested a review from a team August 6, 2024 19:54
@michaeljklein michaeljklein mentioned this pull request Aug 8, 2024
Draft
10 tasks
vezenovm
vezenovm requested changes Aug 8, 2024
View reviewed changes
acvm-repo/acvm/tests/solver.rs Show resolved Hide resolved
acvm-repo/acvm/tests/solver.rs Outdated Show resolved Hide resolved
acvm-repo/acvm/tests/solver.rs Show resolved Hide resolved
acvm-repo/acvm/tests/solver.rs Outdated Show resolved Hide resolved
acvm-repo/acvm/tests/solver.rs Outdated Show resolved Hide resolved
acvm-repo/acvm/tests/solver.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024 •
edited
Loading

Changes to Brillig bytecode sizes

Generated at commit: 1f0ceb21890e6ab72f4ec8967f91565b2b70cac9, compared to commit: cfad664f738c50e2482e411499751f4975f342b7

There are no changes in circuit sizes

@michaeljklein michaeljklein mentioned this pull request Aug 22, 2024
Closed
vezenovm
vezenovm reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@vezenovm vezenovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple nit questions

acvm-repo/acvm/tests/solver.rs Outdated Show resolved Hide resolved
acvm-repo/acvm/tests/solver.rs Show resolved Hide resolved
@michaeljklein michaeljklein added this pull request to the merge queue Aug 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 26, 2024
@michaeljklein michaeljklein added this pull request to the merge queue Aug 26, 2024
Merged via the queue into master with commit 86c151a Aug 26, 2024
48 checks passed
@michaeljklein michaeljklein deleted the michaeljklein/crypto-blackbox-tests branch August 26, 2024 21:39
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Aug 27, 2024
@AztecBot
[1 changes] chore: crypto blackbox tests (noir-lang/noir#5614)
8c033b4 
feat: Improve "type annotations needed" errors (noir-lang/noir#5830)
chore: enum dummy ID for `FuncId` in monomorphizer and docstring fixes (noir-lang/noir#5421)
chore: delete wip fuzzing files that got accidentally added  (noir-lang/noir#5829)
chore: test ACVM `BigInt` (noir-lang/noir#5559)
fix(docs): Fix file paths for metaprogramming docs (noir-lang/noir#5826)
fix: bit shifting type checking (noir-lang/noir#5824)
feat: add Expr::as_method_call (noir-lang/noir#5822)
chore: Fix docs typo (noir-lang/noir#5821)
feat: add `UnresolvedType::is_field` and `Expr::as_assign` (noir-lang/noir#5804)
chore: Add docs for each comptime method (noir-lang/noir#5802)
chore: Add comptime docs (noir-lang/noir#5800)
fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788)
fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810)
fix: honor function visibility in LSP completion (noir-lang/noir#5809)
feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795)
feat: Explicit Associated Types & Constants (noir-lang/noir#5739)
feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801)
feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799)
fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779)
chore: Toggle underconstrained check (noir-lang/noir#5724)
feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784)
feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786)
fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783)
chore: sanitize url's to only allow github (noir-lang/noir#5776)
chore: enable constant inputs for more blackbox (noir-lang/noir#5647)
chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Aug 27, 2024
@AztecBot
chore: crypto blackbox tests (noir-lang/noir#5614)
c77a497 
feat: Improve "type annotations needed" errors (noir-lang/noir#5830)
chore: enum dummy ID for `FuncId` in monomorphizer and docstring fixes (noir-lang/noir#5421)
chore: delete wip fuzzing files that got accidentally added  (noir-lang/noir#5829)
chore: test ACVM `BigInt` (noir-lang/noir#5559)
fix(docs): Fix file paths for metaprogramming docs (noir-lang/noir#5826)
fix: bit shifting type checking (noir-lang/noir#5824)
feat: add Expr::as_method_call (noir-lang/noir#5822)
chore: Fix docs typo (noir-lang/noir#5821)
feat: add `UnresolvedType::is_field` and `Expr::as_assign` (noir-lang/noir#5804)
chore: Add docs for each comptime method (noir-lang/noir#5802)
chore: Add comptime docs (noir-lang/noir#5800)
fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788)
fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810)
fix: honor function visibility in LSP completion (noir-lang/noir#5809)
feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795)
feat: Explicit Associated Types & Constants (noir-lang/noir#5739)
feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801)
feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799)
fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779)
chore: Toggle underconstrained check (noir-lang/noir#5724)
feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784)
feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786)
fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783)
chore: sanitize url's to only allow github (noir-lang/noir#5776)
chore: enable constant inputs for more blackbox (noir-lang/noir#5647)
chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)
@AztecBot AztecBot mentioned this pull request Aug 27, 2024
Merged
TomAFrench added a commit that referenced this pull request Aug 27, 2024
@TomAFrench
Merge branch 'master' into aztec-packages
67d56f7 
* master: (21 commits)
  chore: crypto blackbox tests (#5614)
  feat: Improve "type annotations needed" errors (#5830)
  chore: enum dummy ID for `FuncId` in monomorphizer and docstring fixes (#5421)
  chore: delete wip fuzzing files that got accidentally added  (#5829)
  chore: test ACVM `BigInt` (#5559)
  fix(docs): Fix file paths for metaprogramming docs (#5826)
  fix: bit shifting type checking (#5824)
  feat: add Expr::as_method_call (#5822)
  chore: Fix docs typo (#5821)
  feat: add `UnresolvedType::is_field` and `Expr::as_assign` (#5804)
  chore: Add docs for each comptime method (#5802)
  chore: Add comptime docs (#5800)
  fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (#5788)
  fix(acir_gen): Nested dynamic array initialization (#5810)
  fix: honor function visibility in LSP completion (#5809)
  feat: LSP completion now works better in the middle of idents (#5795)
  feat: Explicit Associated Types & Constants (#5739)
  feat: add `Expr::as_cast` and `UnresolvedType::is_field` (#5801)
  feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (#5799)
  fix: do not use predicate for index in array operation, when the index is safe (#5779)
  ...
sirasistant added a commit to AztecProtocol/aztec-packages that referenced this pull request Aug 27, 2024
@AztecBot @sirasistant @vezenovm
feat: Sync from noir (#8125)
61d6f25 
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: crypto blackbox tests
(noir-lang/noir#5614)
feat: Improve "type annotations needed" errors
(noir-lang/noir#5830)
chore: enum dummy ID for `FuncId` in monomorphizer and docstring fixes
(noir-lang/noir#5421)
chore: delete wip fuzzing files that got accidentally added
(noir-lang/noir#5829)
chore: test ACVM `BigInt` (noir-lang/noir#5559)
fix(docs): Fix file paths for metaprogramming docs
(noir-lang/noir#5826)
fix: bit shifting type checking
(noir-lang/noir#5824)
feat: add Expr::as_method_call
(noir-lang/noir#5822)
chore: Fix docs typo (noir-lang/noir#5821)
feat: add `UnresolvedType::is_field` and `Expr::as_assign`
(noir-lang/noir#5804)
chore: Add docs for each comptime method
(noir-lang/noir#5802)
chore: Add comptime docs (noir-lang/noir#5800)
fix: Handle multiple entry points for Brillig call stack resolution
after metadata deduplication
(noir-lang/noir#5788)
fix(acir_gen): Nested dynamic array initialization
(noir-lang/noir#5810)
fix: honor function visibility in LSP completion
(noir-lang/noir#5809)
feat: LSP completion now works better in the middle of idents
(noir-lang/noir#5795)
feat: Explicit Associated Types & Constants
(noir-lang/noir#5739)
feat: add `Expr::as_cast` and `UnresolvedType::is_field`
(noir-lang/noir#5801)
feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue
(noir-lang/noir#5799)
fix: do not use predicate for index in array operation, when the index
is safe (noir-lang/noir#5779)
chore: Toggle underconstrained check
(noir-lang/noir#5724)
feat: Add `Expr::as_block` and `Expr::has_semicolon`
(noir-lang/noir#5784)
feat: LSP hover and go-to-definition for crates
(noir-lang/noir#5786)
fix(acvm): Clear ACIR call stack after successful circuit execution
(noir-lang/noir#5783)
chore: sanitize url's to only allow github
(noir-lang/noir#5776)
chore: enable constant inputs for more blackbox
(noir-lang/noir#5647)
chore: move sha2 functions into the `hash` module
(noir-lang/noir#5768)
END_COMMIT_OVERRIDE

---------

Co-authored-by: sirasistant <sirasistant@gmail.com>
Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
@AztecBot AztecBot mentioned this pull request Aug 27, 2024
Merged
TomAFrench added a commit that referenced this pull request Aug 28, 2024
@TomAFrench
Merge branch 'master' into tf/keccak-deduplication
edff90f 
* master: (35 commits)
  fix!: Check unused generics are bound (#5840)
  chore(perf): Simplify poseidon2 algorithm  (#5811)
  chore: redo typo PR by nnsW3 (#5834)
  fix(sha256): Perform compression per block and utilize ROM instead of RAM when setting up the message block (#5760)
  chore(perf): Update to stdlib keccak for reduced Brillig code size (#5827)
  chore: crypto blackbox tests (#5614)
  feat: Improve "type annotations needed" errors (#5830)
  chore: enum dummy ID for `FuncId` in monomorphizer and docstring fixes (#5421)
  chore: delete wip fuzzing files that got accidentally added  (#5829)
  chore: test ACVM `BigInt` (#5559)
  fix(docs): Fix file paths for metaprogramming docs (#5826)
  fix: bit shifting type checking (#5824)
  feat: add Expr::as_method_call (#5822)
  chore: Fix docs typo (#5821)
  feat: add `UnresolvedType::is_field` and `Expr::as_assign` (#5804)
  chore: Add docs for each comptime method (#5802)
  chore: Add comptime docs (#5800)
  fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (#5788)
  fix(acir_gen): Nested dynamic array initialization (#5810)
  fix: honor function visibility in LSP completion (#5809)
  ...
TomAFrench added a commit that referenced this pull request Aug 28, 2024
@TomAFrench
Merge branch 'master' into tf/more-comptime-optimization
386a785 
* master: (29 commits)
  fix!: Check unused generics are bound (#5840)
  chore(perf): Simplify poseidon2 algorithm  (#5811)
  chore: redo typo PR by nnsW3 (#5834)
  fix(sha256): Perform compression per block and utilize ROM instead of RAM when setting up the message block (#5760)
  chore(perf): Update to stdlib keccak for reduced Brillig code size (#5827)
  chore: crypto blackbox tests (#5614)
  feat: Improve "type annotations needed" errors (#5830)
  chore: enum dummy ID for `FuncId` in monomorphizer and docstring fixes (#5421)
  chore: delete wip fuzzing files that got accidentally added  (#5829)
  chore: test ACVM `BigInt` (#5559)
  fix(docs): Fix file paths for metaprogramming docs (#5826)
  fix: bit shifting type checking (#5824)
  feat: add Expr::as_method_call (#5822)
  chore: Fix docs typo (#5821)
  feat: add `UnresolvedType::is_field` and `Expr::as_assign` (#5804)
  chore: Add docs for each comptime method (#5802)
  chore: Add comptime docs (#5800)
  fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (#5788)
  fix(acir_gen): Nested dynamic array initialization (#5810)
  fix: honor function visibility in LSP completion (#5809)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vezenovm vezenovm vezenovm approved these changes

@TomAFrench TomAFrench Awaiting requested review from TomAFrench

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit preparedness: test crypto functions
2 participants
@michaeljklein @vezenovm