Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace unused ArrayGet/Set with constrain if possibly out of bounds #5691

Merged
merged 29 commits into from
Aug 13, 2024
Merged

fix: Replace unused ArrayGet/Set with constrain if possibly out of bounds #5691

merged 29 commits into from
Aug 13, 2024

Commits on Aug 6, 2024

  1. Replace unused ArrayGet/Set with constrain if possibly out of bounds

    @asterite
    asterite committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    af686e3 View commit details
    Browse the repository at this point in the history

  2. Add some test programs that should fail

    @asterite
    asterite committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    6f21340 View commit details
    Browse the repository at this point in the history

  3. clippy

    @asterite
    asterite committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    6622719 View commit details
    Browse the repository at this point in the history

  4. clippy again

    @asterite
    asterite committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    71b33e5 View commit details
    Browse the repository at this point in the history

  5. Comment failing tests, for now

    @asterite
    asterite committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    edf6941 View commit details
    Browse the repository at this point in the history

  6. Leave for later the case where index might be simplified

    @asterite
    asterite committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    3fed72a View commit details
    Browse the repository at this point in the history

  7. Make it in two passes

    @asterite
    asterite committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    49c80ad View commit details
    Browse the repository at this point in the history

  8. Fix typo

    @asterite
    asterite committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    165e183 View commit details
    Browse the repository at this point in the history

  9. clippy

    @asterite
    asterite committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    4bcecb1 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Do it right

    @asterite
    asterite committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    0a6bd45 View commit details
    Browse the repository at this point in the history

  2. Better comments

    @asterite
    asterite committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f9fc76e View commit details
    Browse the repository at this point in the history

  3. Consider flattened array length

    @asterite
    asterite committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    0e9494c View commit details
    Browse the repository at this point in the history

  4. Fix a couple of tests

    @asterite
    asterite committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d378768 View commit details
    Browse the repository at this point in the history

  5. Keep track of side effects

    @asterite
    asterite committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ffe067a View commit details
    Browse the repository at this point in the history

  6. Only deal with array instructions, not slice

    @asterite
    asterite committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ad812f3 View commit details
    Browse the repository at this point in the history

  7. Less nesting

    @asterite
    asterite committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    61f2f17 View commit details
    Browse the repository at this point in the history

  8. Handle groups of array_get

    @asterite
    asterite committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    7bdc227 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Better names for test programs

    @asterite
    asterite committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    0361700 View commit details
    Browse the repository at this point in the history

  2. Extract handle_array_get_group

    @asterite
    asterite committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8bae459 View commit details
    Browse the repository at this point in the history

  3. Continue with DIE if no checks were inserted

    @asterite
    asterite committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    a0d18d1 View commit details
    Browse the repository at this point in the history

  4. Small adjustments

    @asterite
    asterite committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8969fb3 View commit details
    Browse the repository at this point in the history

  5. Move function down

    @asterite
    asterite committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    55e26b1 View commit details
    Browse the repository at this point in the history

  6. Comment function

    @asterite
    asterite committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    0eac5c4 View commit details
    Browse the repository at this point in the history

  7. typos

    @asterite
    asterite committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f099ec8 View commit details
    Browse the repository at this point in the history

  8. Remove unused test programs

    @asterite
    asterite committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    aa123a8 View commit details
    Browse the repository at this point in the history

  9. Use Instruction::binary

    @asterite
    asterite committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    4b9538d View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Extract replace_unused_array_instructions_with_bounds_checks optimi… 

    …zation
    @asterite
    asterite committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    ef07ccb View commit details
    Browse the repository at this point in the history

  2. Revert "Extract `replace_unused_array_instructions_with_bounds_checks… 

    …` optimization"

This reverts commit ef07ccb.
    @asterite
    asterite committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    b44203f View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Improve formatting

    @asterite
    asterite committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    be0ef17 View commit details
    Browse the repository at this point in the history