Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(optimization): Perform array gets as early as possible #5762

Closed
wants to merge 27 commits into from
Closed

feat(optimization): Perform array gets as early as possible #5762

wants to merge 27 commits into from

Commits on Aug 19, 2024

  1. Add pass to move array gets

    @jfecher
    jfecher committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9dc626d View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @jfecher
    jfecher committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    913b629 View commit details
    Browse the repository at this point in the history

  3. Add test program

    @jfecher
    jfecher committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d2a63da View commit details
    Browse the repository at this point in the history

  4. Add comment

    @jfecher
    jfecher committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    99d04db View commit details
    Browse the repository at this point in the history

  5. Try increasing size of value merge optimization

    @jfecher
    jfecher committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c94a858 View commit details
    Browse the repository at this point in the history

  6. Update compiler/noirc_evaluator/src/ssa/opt/move_array_gets.rs 

    Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
    @jfecher @vezenovm
    jfecher and vezenovm authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8e96a55 View commit details
    Browse the repository at this point in the history

  7. Update compiler/noirc_evaluator/src/ssa/opt/move_array_gets.rs 

    Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
    @jfecher @vezenovm
    jfecher and vezenovm authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5ead726 View commit details
    Browse the repository at this point in the history

  8. Add comment, tweak constant

    @jfecher
    jfecher committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    91d2312 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'jf/move-array-gets' of https://github.com/noir-lang/noir … 

    …into jf/move-array-gets
    @jfecher
    jfecher committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7856616 View commit details
    Browse the repository at this point in the history

  10. Revert constant value

    @jfecher
    jfecher committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    63a8ec0 View commit details
    Browse the repository at this point in the history

  11. Revert constant again

    @jfecher
    jfecher committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9268c93 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Try changing value merge optimization

    @jfecher
    jfecher committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    244ef0d View commit details
    Browse the repository at this point in the history

  2. Lower constant; rename test; remove unused code

    @jfecher
    jfecher committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    41d3787 View commit details
    Browse the repository at this point in the history

  3. Reduce constant to see runtime difference

    @jfecher
    jfecher committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4005fe9 View commit details
    Browse the repository at this point in the history

  4. Actually just don't array_get at all

    @jfecher
    jfecher committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    0cede20 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Remove ssa file

    @jfecher
    jfecher committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    459893e View commit details
    Browse the repository at this point in the history

  2. Fix end condition

    @jfecher
    jfecher committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    107562e View commit details
    Browse the repository at this point in the history

  3. Use a less radical approach instead

    @jfecher
    jfecher committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    0553153 View commit details
    Browse the repository at this point in the history

  4. Fix warning

    @jfecher
    jfecher committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    aa8cd90 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Merge branch 'master' into jf/move-array-gets

    @jfecher
    jfecher committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    798ef0f View commit details
    Browse the repository at this point in the history

  2. Try crazy optimization

    @jfecher
    jfecher committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    427e387 View commit details
    Browse the repository at this point in the history

  3. Fmt

    @jfecher
    jfecher committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    f771698 View commit details
    Browse the repository at this point in the history

  4. Use odd optimization only on fallback full array merge

    @jfecher
    jfecher committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b5dfcc7 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'jf/move-array-gets' of https://github.com/noir-lang/noir … 

    …into jf/move-array-gets
    @jfecher
    jfecher committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d30d0b4 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Merge branch 'master' into jf/move-array-gets

    @TomAFrench
    TomAFrench authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    fd6ebef View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. .

    @TomAFrench
    TomAFrench committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8c517e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Merge branch 'master' into jf/move-array-gets

    @TomAFrench
    TomAFrench authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3fb0a0e View commit details
    Browse the repository at this point in the history