You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR redirects array_gets to work on earlier arrays if they can (currently only block parameters.
This can potentially optimize code by allowing more array gets to be deduplicated but may also prevent optimizing array_sets to be mutable if older arrays are now being used more.
Additional Context
Documentation*
Check one:
No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.
PR Checklist*
I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.
Maybe. I'm still not sure if this optimization is worth it. Since it'd only have an effect on small programs I think due to the constant limit of how many instructions it can look past to. It also may lead to worse performance if that block parameter had a array_set_mut to it previously but can't anymore since now more array gets to it are inserted.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves comment #5772 (comment)
Summary*
This PR redirects
array_get
s to work on earlier arrays if they can (currently only block parameters.This can potentially optimize code by allowing more array gets to be deduplicated but may also prevent optimizing
array_set
s to be mutable if older arrays are now being used more.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.